Giter Site home page Giter Site logo

Comments (14)

mayurkale22 avatar mayurkale22 commented on July 29, 2024

@bogdandrutu and @SergeyKanzhelev any thoughts?

from opentelemetry-js.

bogdandrutu avatar bogdandrutu commented on July 29, 2024

If the goal is aligned across the SIG members to develop this package node independent I am fine with the raname. @mayurkale22 is everyone on board with this? Do you need an escalation on this?

from opentelemetry-js.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

Should there be another repo like -js-api? node and web may keep corresponding repositories with extra packages. Some logic may be very much node or web specific

from opentelemetry-js.

draffensperger avatar draffensperger commented on July 29, 2024

The downside to separate repos is that then refactoring is kind of hard, because you can't have a single PR that changes the API and also all the users of the API, and it's harder to keep the API in sync in the dependent packages between versions. In contrast, if it's all in one repo, you can make sure that changes to the API package pass all the CI tests for both Node-specific and browser-specific packages.

from opentelemetry-js.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

than it's for @open-telemetry/node-maintainers to decide. If you up for the challenge - than go ahead. There is an inercection of people who knows both worlds. But sometimes people are only familiar with either of two and it may be harder for them to contribute

from opentelemetry-js.

draffensperger avatar draffensperger commented on July 29, 2024

@mayurkale22 could you bring this up in the next SIG and see what people think?

from opentelemetry-js.

mayurkale22 avatar mayurkale22 commented on July 29, 2024

@mayurkale22 could you bring this up in the next SIG and see what people think?

Sure, will update the thread once we have some conclusion after the meeting.

I'd prefer to keep both in the same repo., because we can work on both the version (server and browser) simultaneously without forcing us to publish to npm or other registries to share the types and core packages. And wherever is applicable we can mention, this package is intended for use both on the Node and in the browser.

from opentelemetry-js.

rochdev avatar rochdev commented on July 29, 2024

I prefer a single repo as well. I used to be against it because I believed it promotes coupling, but then I realized that it's very possible to couple many repos together anyway. It also gets really painful to keep multiple repos in sync. This is even more true as the number of repos increases. It's also a lot easier for users who simply want to mix and match different packages if they all use the same version numbers.

from opentelemetry-js.

justindsmith avatar justindsmith commented on July 29, 2024

My initial reaction is (also) to support the single-repo, but we can discuss further in the SIG.

from opentelemetry-js.

draffensperger avatar draffensperger commented on July 29, 2024

What I did to manage keeping the types in sync between opencensus-web and opencensus-node was to write a kind of hacky copy-types script that would extract out only the type files from @opencensus/core for a specific Git commit. This worked around the Node-specific dependencies in @opencensus/core and enabled updating the types incrementally commit-by-commit as they changed in opencensus-node. But keeping it all in one package would simplify this.

For OpenCensus, the web and Node packages only share TS enums/interfaces. But for OpenTelemetry, I think it would be interesting to share actual code in the form of a common platform-neutral API similar to OpenTracing. Then there could be platform specific packages of the API for Node/web.

from opentelemetry-js.

rochdev avatar rochdev commented on July 29, 2024

I believe there was an agreement to rename the repository. We should probably do that sooner rather than later since the more we wait the more contributors will be impacted.

from opentelemetry-js.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

@open-telemetry/node-maintainers can you please confirm that you requesting this change. Happy to accommodate.

from opentelemetry-js.

mayurkale22 avatar mayurkale22 commented on July 29, 2024

@open-telemetry/node-maintainers can you please confirm that you requesting this change. Happy to accommodate.

👍

from opentelemetry-js.

SergeyKanzhelev avatar SergeyKanzhelev commented on July 29, 2024

Renamed

from opentelemetry-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.