Comments (8)
@djMax thanks on answering on the question about donating the implementation of https://github.com/gas-buddy/service/blob/main/src/telemetry/fetchInstrumentation.ts to this repo.
This is the issue we're using to track it's progress. As discussed in the JavaScript SIG (see Dec 13 notes) the goal would be to have a new package named @opentelemetry/instrumentation-undici
which will serve to instrument undici
package and also the global fetch
API. This new package would be placed within experimental/packages
folder along with HTTP & GRPC instrumentations.
Tasks to be done
- Port the code
- Create tests for global
fetch
- Create tests for
undici
package - Add documentation
I can create a draft PR to start so you can give a 1st review or we could do it the other way around. Up to you. :)
from opentelemetry-js.
Happy to review a PR, and to try it out in a place with tests that verify it's function from a consumer perspective.
from opentelemetry-js.
@dyladan @pichlermarc could you assign this one to me? Thanks :)
from opentelemetry-js.
@david-luna Perhaps clarify that this is about Node.js's global fetch()
. IIUC https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-fetch/ instruments fetch()
for web usage. I wonder if that instrumentation might be close to also being able to instrument Node.js's fetch()
. When enabled it shims globalThis.fetch
. That said, the undici diagnostics_channel events from Node's implementation of fetch()
might provide more interesting details for tracing.
from opentelemetry-js.
yeah, it was very short. I've updated with more info :)
from opentelemetry-js.
I've reached the dev who shared his fetch
implementation in the same conversation
#3346 (reply in thread)
I've try another channel if there is no answer in few days
from opentelemetry-js.
This was discussed in the OTel JS SIG today (https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit#heading=h.ry29ajruzxyg). It was concluded to move this instrumentation to the contrib repo.
from opentelemetry-js.
Link to the contrib PR: open-telemetry/opentelemetry-js-contrib#1951
from opentelemetry-js.
Related Issues (20)
- Implement xray-lambda propagator via the OTEL_PROPAGATORS env variable HOT 5
- [@opentelemetry/instrumentation-fetch] Memory leak in NextJS app HOT 8
- ENOENT: no such file or directory, open '/home/webapp/.aws/config' HOT 4
- Baggage : How to use baggae with auto instrumentation web HOT 2
- `@opentelemetry/instrumentation` requires old `@opentelemetry/api-logs` peer dep
- Package subpath './build/src/trace/NoopTracer' is not defined by "exports" HOT 5
- HTTP Timeouts don't seem to retry, resulting in dropped spans HOT 1
- Allow adding links after span creation HOT 2
- Give us the ability to set default option on SugaredTracer
- [instrumentation] replace `cpx2` with a local module in `tests/fixtures/` exclusively for testing
- Implement Jaeger Remote Sampler as defined by the specification HOT 2
- TypeError: timer.unref is not a function HOT 7
- [otlp-exporters] passing an `undefined` header values crashes end-user apps
- [all] replace package.json#browsers with package.json#exports.browser
- Is there a recommended pattern for manually nesting asynchronous trace spans in the browser? HOT 2
- `@opentelemetry/instrumentation/hook.mjs` crashes when loading a module containing `export * from` syntax HOT 3
- Avoid the SemVer v0.x.x anti-pattern HOT 11
- [sdk-node] automatically configure metrics exporter based on enviornment variables
- [sdk-node] automatically configure logs exporter based on enviornment variables HOT 2
- [instrumentation] support ESM instrumentation for Node.js v18.19, v20, v21 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-js.