Giter Site home page Giter Site logo

Comments (8)

david-luna avatar david-luna commented on June 27, 2024 3

@djMax thanks on answering on the question about donating the implementation of https://github.com/gas-buddy/service/blob/main/src/telemetry/fetchInstrumentation.ts to this repo.

This is the issue we're using to track it's progress. As discussed in the JavaScript SIG (see Dec 13 notes) the goal would be to have a new package named @opentelemetry/instrumentation-undici which will serve to instrument undici package and also the global fetch API. This new package would be placed within experimental/packages folder along with HTTP & GRPC instrumentations.

Tasks to be done

  • Port the code
  • Create tests for global fetch
  • Create tests for undici package
  • Add documentation

I can create a draft PR to start so you can give a 1st review or we could do it the other way around. Up to you. :)

from opentelemetry-js.

djMax avatar djMax commented on June 27, 2024 2

Happy to review a PR, and to try it out in a place with tests that verify it's function from a consumer perspective.

from opentelemetry-js.

david-luna avatar david-luna commented on June 27, 2024

@dyladan @pichlermarc could you assign this one to me? Thanks :)

from opentelemetry-js.

trentm avatar trentm commented on June 27, 2024

@david-luna Perhaps clarify that this is about Node.js's global fetch(). IIUC https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-fetch/ instruments fetch() for web usage. I wonder if that instrumentation might be close to also being able to instrument Node.js's fetch(). When enabled it shims globalThis.fetch. That said, the undici diagnostics_channel events from Node's implementation of fetch() might provide more interesting details for tracing.

from opentelemetry-js.

david-luna avatar david-luna commented on June 27, 2024

yeah, it was very short. I've updated with more info :)

from opentelemetry-js.

david-luna avatar david-luna commented on June 27, 2024

I've reached the dev who shared his fetch implementation in the same conversation
#3346 (reply in thread)

I've try another channel if there is no answer in few days

from opentelemetry-js.

trentm avatar trentm commented on June 27, 2024

This was discussed in the OTel JS SIG today (https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit#heading=h.ry29ajruzxyg). It was concluded to move this instrumentation to the contrib repo.

from opentelemetry-js.

david-luna avatar david-luna commented on June 27, 2024

Link to the contrib PR: open-telemetry/opentelemetry-js-contrib#1951

from opentelemetry-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.