Update usage of semantic conventions to new exported strings

[JamieDanielson]

Update usage of semantic conventions to new exported strings

[Prashansa-K]

@JamieDanielson Can I also contribute in this issue? I can start working on this package - @opentelemetry/instrumentation-xml-http-request if no one has picked this up yet.

[Zen-cronic]

@JamieDanielson hey, i found that in each example in the examples/opentelemetry-web directory, there's no usage of @opentelemetry/semantic-conventions. But it's installed as a dep in package.json. And it's already been updated to 1.24.1. So i think the issue list can do without it!

It looks like they are being used for the service name, as seen here in esm-http-ts example. We'll need to replace SemanticResourceAttributes.SERVICE_NAME with the SEMRESATTRS_SERVICE_NAME constant instead. If it helps, take a look at this PR in the js-contrib repo for guidance.

Hey, thanks for the pointers. But i mean that none of the example in the opentelemetry-web imports @opentelemetry/semantic-conventions. For e.g., the code in the fetch example inside opentelemetry-web doesn't use the semantic-conventions package. I hope this clarifies it.

[Zen-cronic]

Oh! I see what you mean now, sorry I read too fast earlier 😅 . It looks like service names were removed inadvertently during an update and migration of this example a few years back actually, so I see we have two options: either remove the semantic conventions package from the package.json since it's not being used, or add the resource and service name for these to match the other examples. I'm leaning toward the second option, what do you think?

No problem at all! Oh i see. Removing the unused dep would be straightforward, but i think we should aim for consistency with the other examples. So, i'm down with the 2nd option too.

[JamieDanielson]

I am working on http package

[mmouru]

PR for instrumentation-fetch #4632

[Prashansa-K]

Created a PR for instrumentation-xhr here: #4681

[JohannesHuster]

I am working on core package.

[JohannesHuster]

I'm working on

• @opentelemetry/shim-opentracing
• @opentelemetry/sdk-trace-web
• @opentelemetry/sdk-trace-node
• @opentelemetry/sdk-trace-base

[Zen-cronic]

hey, i'm working on:

• examples/basic-tracer-node
• examples/esm-http-ts
• examples/grpc-js
• examples/http
• examples/https
• examples/opencensus-shim
• examples/opentracing-shim
• examples/otlp-exporter-node

[Zen-cronic]

@JamieDanielson hey, i found that in each example in the examples/opentelemetry-web directory, there's no usage of @opentelemetry/semantic-conventions. But it's installed as a dep in package.json. And it's already been updated to 1.24.1. So i think the issue list can do without it!

[JamieDanielson]

@JamieDanielson hey, i found that in each example in the examples/opentelemetry-web directory, there's no usage of @opentelemetry/semantic-conventions. But it's installed as a dep in package.json. And it's already been updated to 1.24.1. So i think the issue list can do without it!

It looks like they are being used for the service name, as seen here in esm-http-ts example. We'll need to replace SemanticResourceAttributes.SERVICE_NAME with the SEMRESATTRS_SERVICE_NAME constant instead. If it helps, take a look at this PR in the js-contrib repo for guidance.

[JamieDanielson]

Hey, thanks for the pointers. But i mean that none of the example in the opentelemetry-web imports @opentelemetry/semantic-conventions. For e.g., the code in the fetch example inside opentelemetry-web doesn't use the semantic-conventions package. I hope this clarifies it.

Oh! I see what you mean now, sorry I read too fast earlier 😅 . It looks like service names were removed inadvertently during an update and migration of this example a few years back actually, so I see we have two options: either remove the semantic conventions package from the package.json since it's not being used, or add the resource and service name for these to match the other examples. I'm leaning toward the second option, what do you think?

[JamieDanielson]

I am going to update the remaining items in the resources package

[JamieDanielson]

Also going to update exporter-zipkin, exporter-jaeger, and exporter-prometheus

[Zen-cronic]

i'm on the examples/opentelemetry-web now

[JohannesHuster]

I'm working on sdk-node and opentelemetry-browser-detector.