Access patterns to config in instrumentations

[blumamir]

Access patterns to config in instrumentations

[david-luna]

Here is my opinion. If we already have a public API to access the field I think we should leverage that for accessing even in subclasses. Also I'm not sure about the significance the perf gain of having direct access to the config which is the most appealing pro of option 1.

[pichlermarc]

Here is my opinion. If we already have a public API to access the field I think we should leverage that for accessing even in subclasses. Also I'm not sure about the significance the perf gain of having direct access to the config which is the most appealing pro of option 1.

I agree. IMO we should go with getConfig() and make _config private.

[blumamir]

Pros options 1:

• shorter to write
• bit more performant (I think)

Pros options 2:

• will work correctly for advanced cases if the function is overridden
• can make _config private to decrease API surface.
• aligns will with tracer, meter and logger class properties, which are private and are only accessed via a getter.

[blumamir]

Implemented in open-telemetry/opentelemetry-js-contrib#2289
Would appreciate any review on this PR 🙏