Comments (6)
I usually write dash -
, and since most parts of the repo & contrib seem to be using that. So I'm in favor of aligning it to dash. 🙂
from opentelemetry-js.
I usually write dash
-
, and since most parts of the repo & contrib seem to be using that. So I'm in favor of aligning it to dash. 🙂
Thanks @pichlermarc . Do you suggest we do it only for READMEs, or to all markdown files in the codebase? (including CHANGELOG)
from opentelemetry-js.
Note that the CHANGELOG in the contrib repo is currently generated by release-please which is using *
. Not sure if that is changeable.
I'm on team dash, but I'm also not sure how important it is to enforce. I'm easy.
from opentelemetry-js.
I'm on team dash, but I'm also not sure how important it is to enforce. I'm easy.
I was trying to aggregate data from the READMEs of multiple instrumentations into single markdown, and then we use mixed style and needs to be corrected. Was thinking that it is better to be aligned upstream instead of modifying tools to correct styling downstream in distributions.
created open-telemetry/opentelemetry-js-contrib#2205 to apply in contrib, and will create one for core as well
from opentelemetry-js.
Also team dash generally, but fine with asterisks. I don't feel strongly except to have consistency of using one or the other, so any move in favor of consistency is something I'm on board with 👍
from opentelemetry-js.
fixed in #4713
from opentelemetry-js.
Related Issues (20)
- ConsoleSpanExporter not logging anything for Custom Spans for prebuilds HOT 3
- LogRecord discards attributes which are `instanceof Error` HOT 4
- propagator-aws-xray broken with GRPC? HOT 2
- (draft) [api] document best-practices and limitations
- Types returned by getMeter are not compatible HOT 2
- [instrumentation] hide `shimmer` types from the public API
- How to set `credentials: include`? If it cannot be done, please add an option to include Cookies for the Exporters.
- [instrumentation] research adding experimental features to `Instrumentation`, `InstrumentationBase`
- Can not use ESM support in lambda environment HOT 2
- @opentelemetry/semantic-conventions out of sync. E.g. 1.25.1 `http.user_agent` does not follow semantic conventions? HOT 4
- traceparent http header field is not extracted correctly when datadog agent also inserts it HOT 2
- [instrumentation] update "Instrumentation for ES Modules" documentation HOT 1
- How to determine Parent Span from a ReadableSpan, check if Parent Span is Remote?
- Unable to access to trace information using opentelemetry-js SDK + aws lambda layer HOT 2
- `HttpInstrumentation` does not create outgoing request span for `http.get` in ESM HOT 1
- Lamda Auto Instrumentation Causes -> Internal Server Error Due To Span not Ending HOT 2
- node http integration: ignoreIncomingRequests() option does not work HOT 2
- couchbase instrumentation doesn't not support?
- Logs Stabilization Plan HOT 1
- Update Typescript HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-js.