Comments (10)
I have created issue there too let's see who will do the fix ;)
from opentelemetry-proto.
It should not be limited to base64. It is declared as bytes and any byte sequence should work.
from opentelemetry-proto.
but it doesn't work with bytes, only with base64
from opentelemetry-proto.
Doesn't work with what? That' probably the receiver's fault, not the protocol's. So this issue is probably in the wrong repository.
from opentelemetry-proto.
the proto format says that traceId, spanId and parentId should be bytes, but if you send the data using bytes instead of base64, the opentelemetry collector doesn't work. So this is either wrong description here or opentelemetry collector bug.
from opentelemetry-proto.
I'd say, by definition, the opentelemetry collector has a bug. 😃
from opentelemetry-proto.
@obecny Are you using the JSON with grpc gateway? If yes that is not a bug is the proto limitation, see https://github.com/open-telemetry/opentelemetry-proto/issues/129
from opentelemetry-proto.
See here as well https://developers.google.com/protocol-buffers/docs/proto3#json - bytes are mapped as base64 in JSON representation.
from opentelemetry-proto.
@bogdandrutu yes grpc with json. I don't know about the limitation etc. but when I was implementing this it was saying use bytes which I did, but then the error from collector was not enough to be able to understand what is the problem. We can argue where is the bug, but simply adding some explanation in proto repo that with json you should use base64 would probably save some hours of debugging and trying to figure out what's the problem and if either format is wrong or the receiver - which btw has even much worse documentation and is outdated :).
from opentelemetry-proto.
open-telemetry/opentelemetry-collector#980 (comment) will resolve this issue.
from opentelemetry-proto.
Related Issues (20)
- Why TraceID and SpanID are defined []byte type? HOT 4
- AnyValue diverging from spec on website HOT 2
- The comment of schema_url doesn't describe it's purpose.
- Clarify whether OTLP/gRPC codes should cover both client and server HOT 1
- Unclear whether Span.flags represents span's parent or own flags HOT 10
- Fix releasing notes HOT 3
- Allow consumers to use map<string, AnyValue> instead of repeated KeyValue HOT 3
- Generated OpenAPI files wrongly encode enums
- Improve metrics.proto by mentioning Resource Attributes and Scope HOT 1
- How to use Java service to receive data in the OpenTelemetry (Otel) protocol? HOT 4
- Supporting JSON as-is encoding in OTLP HOT 2
- SPAN_FLAGS_TRACE_FLAGS_MASK is not defined HOT 3
- Fail to push limit HOT 5
- Retryable HTTP Statuses should be configurable HOT 3
- Specify version of the proto that introduced a field in the comments
- File Makefile with executable permissions HOT 2
- Fix outdated attribute examples in comments
- Example not available for Exponential Histogram & Summary metric types
- Define relationship between profile messages and pprof HOT 1
- Consider generalizing profile attributes optimization to other signals
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-proto.