Comments (7)
Isn't an unsampled but exported span an oxymoron? How could this happen in practice?
from opentelemetry-proto.
There is work going on to do tail-based sampling in the collector. For this to work, all spans need to be exported to the collector.
from opentelemetry-proto.
I am +1 on this
from opentelemetry-proto.
@kbrockhoff Do you mind describing more concretely the use case you have in mind? I think with pure tail sampling, we would expect the SDK to do 100% sampling and that wouldn't need to be exported. Is the goal to support multiple sampling decisions, e.g., not sampled for trace, but sampled for logs or for secondary sampling of a subset of the trace? I guess instead of a sampling flag, we'd want a list of SamplingDecision
, each can be namespaced to a backend or system by a user.
Also I think this would need to be propagated too for certain types of secondary sampling?
from opentelemetry-proto.
There are several use cases for having a sampled flag.
-
Using tail-based sampling where the team controlling the tail-based sampling and monitoring does not have control over upfront sampling configuration. This can occur in a supply chain with multiple organizations or even a siloed single organization. In this use case having a list of SamplingDecision as suggested by @anuraaga is an even better idea.
-
Using protobuf as a general storage mechanism for tracing data. An example would be compact storage of a test data set.
In either case, adequate information can potentially be stored in the TraceState field but would then need to be parsed. I can be talked into either this approach or the SamplingDecision approach.
from opentelemetry-proto.
@arminru from the bulk move of P3
required-for-ga
issues to after-ga
earlier today during the issue triage mtg with TC, i noticed this issue was skipped. should the labels for tracking this issue be updated to something else?
from opentelemetry-proto.
This can be added after-ga, if still desired, yes.
@bogdandrutu you were +1 on ths, WDYT?
from opentelemetry-proto.
Related Issues (20)
- Conflicting requirements in OTLP JSON field names HOT 14
- Schema support for span with key-value attributes HOT 2
- Question about ResourceSpans HOT 1
- Mention 1.0.0 in CHANGELOG.md? HOT 3
- Difference between proto and SDK HOT 2
- Why TraceID and SpanID are defined []byte type? HOT 4
- AnyValue diverging from spec on website HOT 2
- The comment of schema_url doesn't describe it's purpose.
- Clarify whether OTLP/gRPC codes should cover both client and server HOT 1
- Unclear whether Span.flags represents span's parent or own flags HOT 10
- Fix releasing notes HOT 3
- Clarify meaning of *DNS name prefix* in protobuf code comment for metric name
- Allow consumers to use map<string, AnyValue> instead of repeated KeyValue HOT 3
- Generated OpenAPI files wrongly encode enums
- Improve metrics.proto by mentioning Resource Attributes and Scope HOT 1
- How to use Java service to receive data in the OpenTelemetry (Otel) protocol? HOT 4
- Supporting JSON as-is encoding in OTLP HOT 2
- SPAN_FLAGS_TRACE_FLAGS_MASK is not defined HOT 3
- Fail to push limit HOT 5
- Retryable HTTP Statuses should be configurable HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-proto.