Giter Site home page Giter Site logo

Comments (6)

AndrewBarber avatar AndrewBarber commented on September 26, 2024 1

No problem on the restructure.

Re: Argyll & Bute, is one county/province. I'll need to go in and combine them on county_province. Thats a bad choice I made I guess! I'll push an update to fix this soon. ๐Ÿ‘

from openbrewerydb.

chrisjm avatar chrisjm commented on September 26, 2024

Awesome! Thanks for working on this @AndrewBarber !

For the directory structure options, I think option 2 or 3 follows the structure and I think I'm leaning towards option 3. What do you think?

Re: the CSV structure, this StackOverflow post (https://stackoverflow.com/questions/929684/is-there-common-street-addresses-database-design-for-all-addresses-of-the-world) suggests county_province which I think will cover more countries.

Additionally, does it make sense to add more address lines? ex. address_2, address_3?

from openbrewerydb.

AndrewBarber avatar AndrewBarber commented on September 26, 2024

Dir Structure - Sure 3 looks great!
CSV Structure - I think county_province works for this. I also think that address_2 & address_3 lines would work as optional fields, and would help with address structure.

from openbrewerydb.

chrisjm avatar chrisjm commented on September 26, 2024

Great! If you're able to work on some CSVs, I'll get the DB prepped for the extra columns.

from openbrewerydb.

chrisjm avatar chrisjm commented on September 26, 2024

Closed by #43

from openbrewerydb.

chrisjm avatar chrisjm commented on September 26, 2024

Heya, @AndrewBarber !

As I was updating the automation scripts, I decided to update the directory structure to match what's available in the CSV which made it easier to code. So now the structure is data/scotland/[county]. Also, the script splits on either county_province or state so Argyle and Bute were split.

Look it over and let me know what you think!

from openbrewerydb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.