Comments (6)
No problem on the restructure.
Re: Argyll & Bute, is one county/province. I'll need to go in and combine them on county_province. Thats a bad choice I made I guess! I'll push an update to fix this soon. ๐
from openbrewerydb.
Awesome! Thanks for working on this @AndrewBarber !
For the directory structure options, I think option 2 or 3 follows the structure and I think I'm leaning towards option 3. What do you think?
Re: the CSV structure, this StackOverflow post (https://stackoverflow.com/questions/929684/is-there-common-street-addresses-database-design-for-all-addresses-of-the-world) suggests county_province
which I think will cover more countries.
Additionally, does it make sense to add more address lines? ex. address_2
, address_3
?
from openbrewerydb.
Dir Structure - Sure 3 looks great!
CSV Structure - I think county_province
works for this. I also think that address_2
& address_3
lines would work as optional fields, and would help with address structure.
from openbrewerydb.
Great! If you're able to work on some CSVs, I'll get the DB prepped for the extra columns.
from openbrewerydb.
Closed by #43
from openbrewerydb.
Heya, @AndrewBarber !
As I was updating the automation scripts, I decided to update the directory structure to match what's available in the CSV which made it easier to code. So now the structure is data/scotland/[county]
. Also, the script splits on either county_province
or state
so Argyle and Bute were split.
Look it over and let me know what you think!
from openbrewerydb.
Related Issues (20)
- Question: How to handle closed breweries? HOT 4
- Some Bad Characters in Data: ยฉ -> ๏ฟฝ or ยฉ -> รขย HOT 3
- BREAKING CHANGES: Update database schema HOT 7
- International translations
- Add Cloudflare Cache Cleaner Github Action HOT 1
- Github Action > Update Open Brewery DB API HOT 6
- OpenStreetMap database ? HOT 1
- Broken search by keyword and autocomplete queries HOT 2
- Autocomplete endpoint does not match documentation HOT 3
- Add Contributors HOT 10
- Add gzipped versions of datasets HOT 1
- ArcGIS REST Service HOT 15
- Replace `frictionless` with `csv-file-validator`
- Add US Census data
- Add Breweries with missing/not enough data HOT 7
- CLI tool to create obdb_id
- Discussion: Scraping for brewery data
- Fix how international phone numbers are handled HOT 7
- Add Brewery Data Change Manager
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openbrewerydb.