test_conditional_instantiation_1 triggers warnings in pattern engine

[opencog]

test_conditional_instantiation_1 triggers warnings in pattern engine

[linas]

BTW, to add injury to insult -- sometimes, the BCUtest passes, and sometimes it fails. I didn't notice that it sometimes fails, circle-ci was happy, so I merged. But now, its failing more often, and unrelated changes are causing it to get messed up. :-/ ... In particular, I cannot merge opencog/atomspace#2630 even though BCUTest works the same way, before and after that patch.

[linas]

Disabled the unit tests that error out in #88 until this is resolved somehow.

[linas]

This branch fixes things so that BackwardChainer runs, without any errors:

https://github.com/linas/atomspace/tree/mandatory-unquoted-clauses

However, two atomspace unit tests fail. I'm thinking of nuking the failing atomspace unit tests, because I do not believe that are realistic, or do they test wanted behavior. Actually, they are valid tests.

[linas]

Fixed in #2633 ... thank you for paying attention. #88 can now be reverted.

[linas]

Closing. Everything is now fixed. Sorry for the interruption.

[ngeiswei]

OK. I'm glad there's nothing to fix on my part, however I'm seeing that rules of that test do not make use of PresentLink, which I'd like to fix.