newly added tests are broken on big endian arches

[opendap]

newly added tests are broken on big endian arches

[sharkcz]

For the record current HEAD gives

==============================================
   libdap 3.19.1: unit-tests/test-suite.log
==============================================

# TOTAL: 51
# PASS:  49
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: Int16Test
===============

...F.F........


!!!FAILURES!!!
Test Results:
Run:  12   Failures: 2   Errors: 0


1) test: libdap::Int16Test::val2buf_test (F) line: 132 Int16Test.cc
assertion failed
- Expression: i2->value() == 42


2) test: libdap::Int16Test::buf2val_test (F) line: 142 Int16Test.cc
assertion failed
- Expression: i2->buf2val(&v) == 2 && i == 0


FAIL Int16Test (exit status: 1)

FAIL: UInt16Test
================

...F.F........


!!!FAILURES!!!
Test Results:
Run:  12   Failures: 2   Errors: 0


1) test: libdap::UInt16Test::val2buf_test (F) line: 132 UInt16Test.cc
assertion failed
- Expression: i2->value() == 42


2) test: libdap::UInt16Test::buf2val_test (F) line: 142 UInt16Test.cc
assertion failed
- Expression: i2->buf2val(&v) == 2 && i == 0


FAIL UInt16Test (exit status: 1)

[sharkcz]

Unfortunately the fix didn't help, I get still the same failure in Int16Test and UInt16Test. @captainkirk99 - send me an email to sharkcz at fedoraproject dot org, if you need access to a big endian machine.

[captainkirk99]

@sharkcz does ByteTest work for you now?

[captainkirk99]

OK, dumb mistake. (But aren't most bugs?) I will have a PR with a fix for Int16Test and UInt16Test shortly.

[captainkirk99]

@sharkcz can you check the current master on your big-endian machine? It should work.

Also, what machine are you using? I didn't know there were really any big-endian machines out there any more...

[sharkcz]

re ByteTest - it was broken only(?) when the test was introduced, at the end only the Int16Test and UInt16Test were broken

yes, all tests are now passing

re big endian - in Fedora we have big endian arches - s390x (the mainframes) and ppc64, although the little endian variant (ppc64le) is the future, ppc64 is being deprecated

[captainkirk99]

OK, thanks!