Giter Site home page Giter Site logo

Comments (3)

kdmccormick avatar kdmccormick commented on July 26, 2024

@bradenmacdonald , Here's the current ScopeIds definition:

class ScopeIds(namedtuple('ScopeIds', 'user_id block_type def_id usage_id')):
    ....

I'm thinking we could change it to something like:

class ScopeIds(NamedTuple):
    user_id: int  # or just 'object'?
    block_type:  str
    def_id: DefinitionKey
    usage_id: UsageKey

do you agree?

from xblock.

bradenmacdonald avatar bradenmacdonald commented on July 26, 2024

This is great, @kdmccormick

Just need to investigate the type of user_id a bit more. I know it can be None sometimes when an XBlock is not "bound" to a particular user. And at least in the "new runtime", an anonymous user gets a string ID. So I think it should be typed as int|str|None.

Example: https://github.com/openedx/edx-platform/blob/2cd1410d9951f0b5cd1639f25dd34e191d4d75f3/openedx/core/djangoapps/xblock/runtime/runtime.py#L110-L117

from xblock.

kdmccormick avatar kdmccormick commented on July 26, 2024

I'm currently doing this in tandem with #707 , implemented by #713.

My thinking is that we'll make the change, bump the major version of XBlock, and pin xblock-sdk to an older version of XBlock.

Following up, we should either deprecate xblock-sdk, or a find a maintainer for it who is willing to remove the XBlock version pin.

from xblock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.