Create new encounter & New Validation

[openemr]

Create new encounter & New Validation

[bradymiller]

Thanks for this bug report.

This setting is only supposed to turn on/off the new validation method in the forms driven by the layouts engine.

It is not supposed to turn on/off the new validation method in the separate forms (such as the new encounter that ophthal pointed out), which are instead controlled by their associated entry in list_options.

(I have confirmed that this global new_validate is being used within the core validation functions, which is what is causing the bug)

@sharonco-matrix , Can your group look at this?

[sharonco-matrix]

We will fix it!

[bradymiller]

Hi @sharonco-matrix ,

There appear to be 2 related PR's for this now:
#287
#288

I don't think this it is necessary to try and support 2 separate validation mechanisms in these forms, which will just be confusing; and your group's validation method is much more modern and flexible. If the entry is missing in list_options or it is turned off in list_options, then this is an error on the user's part.

The bug that needs to be fixed, though, is that all these forms(with entries in list_options) are breaking if the Administration->Globals->Security->'New Form Validation' is turned off. This flag should not affect these forms at all and should only be used to turn off/on the validation in the layout based forms.

thanks,
-brady

[bradymiller]

Fix for this has been posted here and is under review:
#294

[bradymiller]

I just committed the above linked PR which fixes this issue(thank you @sharonco-matrix for the fix). There is still a minor clean up issue in library/validation/validate_core.php, so will leave this issue open until that is addressed.

[bradymiller]

Minor fix has been addressed, so closing this issue.