Closing a tab not warning of unsaved changes

[openemr]

Closing a tab not warning of unsaved changes

[stephenwaite]

hi @tywrenn , that was just for the soap form
#3303 (comment)

[bradymiller]

My thoughts here, are that in the tabs layout, need the following to happen when a user is editing a form:

1. Warn of unsaved changes if try to close the tab.
2. Warn of unsaved changes if try to open another screen that will overwrite the tab with the form in it.

[sunsetsystems]

Agree. But seems the beforeunload handler should trigger in either case? So maybe mostly a matter of finding out why it's not working.

[bradymiller]

Hi,
Can you post the code as a Pull Request?
thanks,
-brady

[bradymiller]

I just reviewed this fix. Rather than ask if ok to close the tab (which will become tedious for users), need to incorporate the beforeunload handler in the pertinent forms. To see example, recommend looking at use of this in the openemr/interface/forms/LBF/new.php script.

[bradymiller]

@sunsetsystems ,
I am only seeing the beforeunload handler being used in the openemr/interface/forms/LBF/new.php script. Were there other places that had a mechanism to prevent losing information in the frames UI?

[sunsetsystems]

Yes it was also done for demographics and the layout editor. Commit is here:
364afe2

[robertdown]

Hi @rishabhemr can you submit a pull request here on github with those changes for review? Thanks!

[stale]

This issue has been automatically marked as stale because it has not had any recent activity within the past 90 days. It will be closed in 7 days if no further activity occurs.

[tywrenn]

Bump -- this should've been added

[stephenwaite]

we're getting closer with #3303

[tywrenn]

@stephenwaite Looks like that merged -- time to close this

[stale]

This issue has been automatically marked as stale because it has not had any recent activity within the past 90 days. It will be closed in 7 days if no further activity occurs.

[tywrenn]

Bump