Comments (6)
The OEP API now checks for id fields and duplicate column names: OpenEnergyPlatform/oeplatform#1032
As far as I know, the API does not check for all table conventions (like capital letters).
@wingechr correct me if I'm wrong :)
The "create table" tool checks for uppercase letters, but other tools like oem2orm do not.
Since this is a compliance issue for the OEP, we should include such checks in the API. We should not trust user input and rely on other developers to implement all checks in their tools.
from oem2orm.
completely agree. i will have a look at the api side and if necessary implement name checks
from oem2orm.
oem2orm has no checks for the oedb table naming conventions. However, it should be implemented in oem2orm or in the API itself.
from oem2orm.
The same set of checks should apply for the Wizzard too.
from oem2orm.
Are there any updates on the issue?
I uploaded a table to test the status: https://openenergy-platform.org/dataedit/view/model_draft/umas_2021_05_18_resources_name_check_2
There're checks, however the error messages are heterogenous and should be improved. Not sure if the checks stem from the OEP API checks rather than sqlalchemy internal.
Implemented checks for columns headers
- starting col with number - bad/unspecific error message
- special characters - bad/unspecific error message
- capital letters - specific error message, but no column specified
from oem2orm.
checks could be some regular expression, like [a-z][a-z0-9_]{0,62}
from oem2orm.
Related Issues (18)
- the installation is failing HOT 2
- Update pypi package with new release
- Parsing error when opening metadata
- Metadata is not uploaded to OEP in case of single table
- Feature Request: Create tables from OEM json/dict as well HOT 1
- Metadata to ORM feature HOT 15
- Error while updating metadata on OEP is not forwarded HOT 2
- Update Readme on PyPi
- Improve error and status messages when uploading tables HOT 2
- Handle single table objects, not list of tables
- How to clean release: Commits differ on master and develop post release HOT 2
- Upload with oem2orm dtype `int` is interpreted as `bigint`
- Update requirements.txt HOT 4
- Improve Docs
- Add new Issue-Templates
- Improve error messages
- OEDialect and SQLAlchemy versions not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oem2orm.