Giter Site home page Giter Site logo

Comments (6)

jh-RLI avatar jh-RLI commented on July 30, 2024 2

The OEP API now checks for id fields and duplicate column names: OpenEnergyPlatform/oeplatform#1032

As far as I know, the API does not check for all table conventions (like capital letters).
@wingechr correct me if I'm wrong :)
The "create table" tool checks for uppercase letters, but other tools like oem2orm do not.
Since this is a compliance issue for the OEP, we should include such checks in the API. We should not trust user input and rely on other developers to implement all checks in their tools.

from oem2orm.

wingechr avatar wingechr commented on July 30, 2024 2

completely agree. i will have a look at the api side and if necessary implement name checks

from oem2orm.

chrwm avatar chrwm commented on July 30, 2024

oem2orm has no checks for the oedb table naming conventions. However, it should be implemented in oem2orm or in the API itself.

from oem2orm.

chrwm avatar chrwm commented on July 30, 2024

The same set of checks should apply for the Wizzard too.

from oem2orm.

chrwm avatar chrwm commented on July 30, 2024

Are there any updates on the issue?
I uploaded a table to test the status: https://openenergy-platform.org/dataedit/view/model_draft/umas_2021_05_18_resources_name_check_2

There're checks, however the error messages are heterogenous and should be improved. Not sure if the checks stem from the OEP API checks rather than sqlalchemy internal.

Implemented checks for columns headers

  1. starting col with number - bad/unspecific error message
  2. special characters - bad/unspecific error message
  3. capital letters - specific error message, but no column specified

from oem2orm.

wingechr avatar wingechr commented on July 30, 2024

checks could be some regular expression, like [a-z][a-z0-9_]{0,62}

from oem2orm.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.