SysML Model WP3-Initial-Architecture

[openetcs]

SysML Model WP3-Initial-Architecture

[vgontier]

Hello,
I just have a look to the ManageLocationInformationIBD. But I am not sure it is the right one because I do not find the data Uwe is talking about :-(
I have some method remarks about this figure:
A/ some blocks have the same id. It is not a good practise : you shall never find the same id for two different objects in one project. And it would be better to have a hierarchy identification system. I propose (F=Function):
F.1 Manage Balise Information
F.1.1 Perform Eurobalise Decoding
F.1.2 Build BG Message
F.1.3 Check BG Consistancy
F.1.4 Determine BG Orientation
F.1.5 Select Usable Information
F.2 Manage Train Position
F.2.1 Valid Data Direction
F.2.2 Calculate Train Position
F.2.3 Manage Position Report
F.3 Manage On Board Data
F.4 Manage Data To And From DMI
F.5 Manage RBC_Data
F.6 Initialise Train Data

B/ It would be better to have the same case for inputs / outputs (lower or upper: choose !)

C/ Don't mix variable and variable value as input / output
Exemple
in BTM_Info: BTM_INFO_T. BTM_INFO_T is the name of the variable
out RBCReport: is the value... of an unknowned variable.
A value can not be an function input or output. Only a variable name can be.

D/ Why is « Booleen » specified in the variable name and not the other types? (I think it would be better to specified this information in an other place: the figures are too large and very difficult to read because there is too many information on they)

E/ May be it is one SysML rule, but it is really complicated and heavy to give the variable name and the target / supplier function to each end of the data lines. And it is a source of errors: for exemple « Telegrame header » becomes « header » between input and output of BuildBGMessage (and AdditionPacket ListOfAdditionInformation).
It would be better to write only the variable name and only one time: if you want to know the supplier or target function, you can open the main function to have more details.

F/ Some inputs and outputs are not defined.
See: 3 inputs and 1 output of ValidDataDirect, 1 output of CalculateTrainPosition

G/ TrainPositionInfo instead of TrainPosionInfo (CalculateTrainPosition ouput)

H/ What is the difference between TrainInfo and TrainInformation (2 ManageOnboardData outputs) ?

I/ I do not understand the model and I can not check if the figure it is right or not because I do not find the function description document on Github. Can you tell me where it is?

Best regards
Véronique

[vgontier]

Github don't like some caracteres...
So...
C/ Don't mix variable and variable value as input / output
Exemple
in BTM_Info: BTM_INFO_T. BTM_INFO_T is the name of the variable
out RBCReport: (undefined) (undefined) is the value... of an unknowned variable.

[UweSteinkeFromSiemens]

Do you really refer to the model https://github.com/openETCS/modeling/blob/master/model/sysml/WP3-Initial-Architecture/WP3-Initial-Architecture.di. Correct ?

[vgontier]

Correct !

[christiangiraud]

Hi,
I try more or less to make a convergence with WP3_DataBase_V9,

•      F1 is the box A2,
  

•      F2 is the box A8,
  

•      F3 is the box  A3,
  

•      F4 is the box  A1,
  

•      F5 is the box A4,
  

•      Etc…
  

  A work of convergence is needed.

After analysis, it seems that “Balise Recept” and “Train Positioning” are very linked.

Cdt
CG

De : Véronique Gontier [mailto:[email protected]]
Envoyé : lundi 1 septembre 2014 16:14
À : openETCS/SRS-Analysis
Objet : Re: [SRS-Analysis] SysML Model WP3-Initial-Architecture (#36)

Hello,
I just have a look to the ManageLocationInformationIBD. But I am not sure it is the right one because I do not find the data Uwe is talking about :-(
I have some method remarks about this figure:
A/ some blocks have the same id. It is not a good practise : you shall never find the same id for two different objects in one project. And it would be better to have a hierarchy identification system. I propose (F=Function):
F.1 Manage Balise Information
F.1.1 Perform Eurobalise Decoding
F.1.2 Build BG Message
F.1.3 Check BG Consistancy
F.1.4 Determine BG Orientation
F.1.5 Select Usable Information
F.2 Manage Train Position
F.2.1 Valid Data Direction
F.2.2 Calculate Train Position
F.2.3 Manage Position Report
F.3 Manage On Board Data
F.4 Manage Data To And From DMI
F.5 Manage RBC_Data
F.6 Initialise Train Data

B/ It would be better to have the same case for inputs / outputs (lower or upper: choose !)

C/ Don't mix variable and variable value as input / output
Exemple
in BTM_Info: BTM_INFO_T. BTM_INFO_T is the name of the variable
out RBCReport: is the value... of an unknowned variable.
A value can not be an function input or output. Only a variable name can be.

D/ Why is « Booleen » specified in the variable name and not the other types? (I think it would be better to specified this information in an other place: the figures are too large and very difficult to read because there is too many information on they)

E/ May be it is one SysML rule, but it is really complicated and heavy to give the variable name and the target / supplier function to each end of the data lines. And it is a source of errors: for exemple « Telegrame header » becomes « header » between input and output of BuildBGMessage (and AdditionPacket ListOfAdditionInformation).
It would be better to write only the variable name and only one time: if you want to know the supplier or target function, you can open the main function to have more details.

F/ Some inputs and outputs are not defined.
See: 3 inputs and 1 output of ValidDataDirect, 1 output of CalculateTrainPosition

G/ TrainPositionInfo instead of TrainPosionInfo (CalculateTrainPosition ouput)

H/ What is the difference between TrainInfo and TrainInformation (2 ManageOnboardData outputs) ?

I/ I do not understand the model and I can not check if the figure it is right or not because I do not find the function description document on Github. Can you tell me where it is?

Best regards
Véronique

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-54064364.

---

CONFIDENTIALITY : This e-mail and any attachments are confidential and may be privileged. If you are not a named recipient, please notify the sender immediately and do not disclose the contents to another person, use it for any purpose or store or copy the information in any medium.

[UweSteinkeFromSiemens]

Results from the Goto Meeting ( @vgontier , @Farhangi , @UweSteinkeFromSiemens ):

• The SysML model has to be updated according to the SCADE model
• The models should use a consistent naming convention for inputs and outputs (upper or lower case, ...)
• The parts in the SysML model must have dedicated names assigned, reflecting the model hierarchy like "F.1.1" (see above)
• The types of all inputs and outputs must be set.
• The types of inputs and outputs should be hidden in the IBDs.
• All inputs and outputs of sub-blocks have to be wired.

[vgontier]

Hello,
The model is more legible with this new presentation !
Is it possible to have the same name for the same item (as input and as output, in each block ?) ? At the moment, is it impossible to have an unambigous description of inputs / outputs
@UweSteinkeFromSiemens @Farhangi