Add a hidden option to authenticate scan queries

[teolemon]

Add a hidden option to authenticate scan queries

[teolemon]

I'd like to get feedback on the monday Product Opener call before we move on that one.
There are privacy implications, and there are functional implications (how we want to do it).

[monsieurtanuki]

@teolemon Generally speaking, would that mean systematically setting the app user parameter each time we query the server?
I've just had a look at the code and it looks like we systematically add the user to product-read server queries, except for single product refreshes (which are the most common, e.g. the refresh after product change).
In product_refresh.dart:

      final ProductResultV3 result = await OpenFoodAPIClient.getProductV3(
        getBarcodeQueryConfiguration(
          barcode,
          language,
        ),
        uriHelper: ProductQuery.uriProductHelper,
        // just add this parameter, that already exists -> user: ProductQuery.getUser(),
      );

That wouldn't be a hidden option, that would just be "From now on Smoothie always sends you the user, do whatever you want on the server side with that additional info".

Would only take 5 minutes to PR.

[teolemon]

I got feedback, it should be ok for all logged in users that have enabled the analytics collection

[monsieurtanuki]

@teolemon Let me summarize the current status.
If the user is logged in, we ALWAYS send the user in our server queries (READ/WRITE) except in one case: single product refresh (that we use all the time) where no user is provided.

Obviously we need to add the user parameter to the last remaining case (single product refresh), in order to match the needs from OP.

On the other hand, if it is considered as "inappropriate tracking", we should NOT use the user param in any READ server query when the user specified that no analytics should be performed. Assuming that using it for WRITE is tacit common sense.