Giter Site home page Giter Site logo

Comments (2)

g123k avatar g123k commented on July 26, 2024

Today, the button turns green when a photo with the correct type/(default) language is available.
The problem is when the photo was taken in a different language.

Here are a few possible fixes:

  • The photo screen returns a Boolean to indicate whether a photo has been added/edited.
  • The photo screen returns a List of languages added/modified.
    -> Option 1: In both cases, if the result is not empty, we can assume it's OK

But the photo may still be sent in the background.
Option2: Should we then go with a List of languages AND do the same check as today… but with the correct language

(cc @monsieurtanuki @teolemon)

from smooth-app.

monsieurtanuki avatar monsieurtanuki commented on July 26, 2024

@g123k Actually we don't care if the background task hasn't been completed yet: we override the product with the pending data.

Quickly said: I would have a look at BackgroundTaskUpload, method getProductChange and

  @override
  Future<void> preExecute(final LocalDatabase localDatabase) async {
    await localDatabase.upToDate.addChange(
      uniqueId,
      getProductChange(),
    );
    await putTransientImage(localDatabase);
  }

Including UpToDateChanges._overwrite too, the way it deals with images.

Then, I guess looping the product images looking for at least one "nutrition" picture would be enough.

from smooth-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.