Comments (2)
cholmes
commented on June 4, 2024
1
Hey @felix-schott - that'd be awesome! I am totally happy with pytest if you're up to contribute. To be honest I've never written tests in Python - this is my first python coding project, so I'm more than happy for any guidance. And once the tests framework is in place I'll be sure to make use of it. And refactoring is definitely completely welcome as well, and it would be great to have a nice python interface.
from open-buildings.
felix-schott
commented on June 4, 2024
Hi Chris,
Do you mind if the tests use pytest instead of the unittest module? If so, I'll add some tests in the next couple days (I'm more comfortable with pytest). Note that it'll be easier to unit test things if the download function is decoupled from the CLI functionality. Also nicer to have a proper Python interface as this allows for more complex scripting applications. So the changes might involve some refactoring. I'm having a go locally and will push a PR in the next few days if you're fine with that!
Cheers
Felix
from open-buildings.
Related Issues (20)
- Automatically calculate country codes per quadkey & remove country_iso flag HOT 2
- Option to just get the 'count' of buildings, but not actually download the results. HOT 2
- Better progress reporting in `get_buildings` HOT 1
- Make get building requests with smaller quadkeys
- Better estimates of how long a query might take
- Warn users if their geojson is not in `iso_country`
- Don't create empty files if there are 0 features
- Create QGIS plugin for get_buildings HOT 2
- Install spatial extension if not installed HOT 3
- Add a geocoding option HOT 2
- Tidy up requirements.txt
- Structure of the package
- Python interface for functionality
- Cannot save as Shapefile HOT 10
- Allow both .geojson and .json as suffixes to mean output as GeoJSON
- Accept more input formats HOT 2
- Installation requirement files and dependencies HOT 3
- Nicer error reporting when geocoder fails HOT 6
- Document version of data used HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-buildings.