Unbundle Memorizing Trust Manager

[openhab]

Unbundle Memorizing Trust Manager

[dominicdesu]

Hello,
running gradle tasks --info shows:

...
Evaluating project ':submodules:MemorizingTrustManager' using empty build file.
FAILURE: Build failed with an exception.
A problem occurred configuring project ':mobile'.
> Configuration with name 'default' not found.

Is it possible that the build.gradle in subproject 'mobile' cannot access the submodules of the root project?

[Flowdalic]

gradle tasks --info works for me. Could it be that you didn't checkout the git submodule?

[dominicdesu]

Hi,
indeed, I hadn't checked out the submodule. I'm not familiar with the git submodules and assumed that gradle would somehow resolve the dependency. Is it normal that this manual step is necessary?

After checking out the submodule, I get errors in OpenHABMainActivity like
Error:(79, 23) error: cannot find symbol class MemorizingResponder or
Error:(863, 53) error: DECISION_INTENT is not public in MemorizingTrustManager; cannot be accessed from outside package

And I can't find for example a MemorizingResponder in the submodule (or anywhere else). Did I check out some wrong version?
You say that the branch doesn't compile in Android Studio. What kind of error is display?

[Flowdalic]

I'm not familiar with the git submodules and assumed that gradle would somehow resolve the dependency. Is it normal that this manual step is necessary?

Gradle is agnostic of the used VCS. There is no relation between gradle and a submodule. Or in other words: Both are living on different layers.

Did I check out some wrong version?

submodules are always tied to a particular revision. So if you didn't (accidentally) issued the command to change that version, you will always get the version I've used.

I get the same (or at least) similar compiler warnings (which I already stated in the initial message). But it seems I got AS now at least working (I usually develop in Emacs or Eclipse). Let's see if I can update the PR to a buildable state. Stay tuned.

[belovictor]

So what is this issue about at the end of the day? :-) I don't think that moving MTM into a separate project would make anything better.

[Flowdalic]

I don't think that moving MTM into a separate project would make anything better.

I think it would (given you mean also that it would become a git submodule). For multiple reasons:

• It makes it easier to determine the currently used version of MTM
• You can easily update/replace MTM by changing the commit the git submodule points to

Older MTM version have some issues, and I can't determine (without comparing the source), if the one used by habdroid is affected.

[belovictor]

Unless MTM project provide a usable external dependancy there is no option to separate it. There is some activity in the MTM project to publish the library. As soon as they do it, I will switch to this dependancy and remove MTM code from openHAB app.

[Flowdalic]

Unless MTM project provide a usable external dependancy there is no option to separate it.

You can already use MTM by simply adding it as git submodule. Neither I or Ge0rg (as far as I know) plan to publish it as artifact to e.g. maven central.