Giter Site home page Giter Site logo

Comments (6)

kaikreuzer avatar kaikreuzer commented on May 25, 2024

This is a constraint due to using log4j - afaik, you cannot change it in log4j.
See also openhab/openhab-addons#384

from openhab-distro.

dvanherbergen avatar dvanherbergen commented on May 25, 2024

So that leaves three options:

  • change pax-logging to use logback rather than log4j. Pax logging supports all loggers.
  • add a custom layout formatter to use with Log4J
  • change the format to print the fully qualified name without trimming

Leaving it as is, will cause much frustrations (at least for me...)

from openhab-distro.

kaikreuzer avatar kaikreuzer commented on May 25, 2024

I would still tend to go with logback again.
I only wonder if @maggu2810's fear (openhab/openhab-addons#384 (comment)) is right and that this would mean that we cannot use log:set? This is currently the only way to enable debug logging, so this is something we should not lose.

from openhab-distro.

dvanherbergen avatar dvanherbergen commented on May 25, 2024

The pax-logging-service log4j backend is the only one that implements all the log commands correctly.
I had a look at the other implementations (log4j2 and logback) and there is still a bit of work to be done before those support all the commands.
I had a first attempt at using a custom formatter, but it turns out that all the log4j classes have been repackaged inside the pax-logging-service jar and none of them have been exported, so these aren't accessible causing this approach to fail.
I'll investigate further to see how we can get this to work decently.

from openhab-distro.

dvanherbergen avatar dvanherbergen commented on May 25, 2024

The logging service will change to log4j2 in karaf 4.1.0. This will allow the use of new layouts, so it doesn't make any sense to make changes to the logging approach now.

from openhab-distro.

kaikreuzer avatar kaikreuzer commented on May 25, 2024

Sounds good!

from openhab-distro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.