Warning if no JAVA_HOME is set

[openhab]

Warning if no JAVA_HOME is set

[dvanherbergen]

This message is generated by the karaf start shell script. I don't think we should modify that one.
Isn't setting JAVA_HOME a good practice anyway?

[kaikreuzer]

Isn't setting JAVA_HOME a good practice anyway?

Well, I came across it because I simply setup Raspian, installed the JDK through apt-get and then openHAB. Since the JDK install did not set JAVA_HOME this was missing and I guess I won't be the only one coming across it. And if a missing JAVA_HOME has no consequence, why bother?

[dvanherbergen]

I guess we should ask the Karaf guys why "results may vary" 😄

[maggu2810]

IIRC JAVA_HOME was used in the past by various software component to locate the path of the JDK (and so the bundled JRE). Some linux distributions uses it, some not.
The simplest workaround if you want to get rid of this message till monday is IMHO to copy locateJava function (e.g. of the bin/karaf script) to the start.sh file (same for .bat) and set JAVA_HOME the same way it is done there if it is not set already.

No consequence is not granted as long as you do not know every line of code if someone is using that environment variable.

Just my two cents if you need a workaround to remove this message...

[kaikreuzer]

On my RasPi, I now see the following at startup:

pi@raspberrypi:~/oh $ ./start.sh 
Launching the openHAB runtime...
java is /usr/bin/java
/usr/bin/java

This does not look like the final solution yet :-)

[dvanherbergen]

oops. Looks like I somehow left ome debug info in there :-)
A fix is on its way..