Giter Site home page Giter Site logo

Comments (6)

Kubik42 avatar Kubik42 commented on July 23, 2024

Good point. The Python example was just a general case I wanted to present, it has nothing to do with the guide. I suppose I can do the same analogy but with java. As for being Open Liberty specific, I though we wanted to not focus on open liberty and microprofile? Hence, the whole rework concerning the titles of the guides. My understanding is that users would want to learn about Docker and we teach them, but it just so happens that we use Open Liberty for it. This makes users more inclined to chose OL for future docker work since they are already sort of accustomed to it.

from guide-docker.

lauracowen avatar lauracowen commented on July 23, 2024

Yeah, JavaEE/MP is the relevant bit as you say. Java EE/MP spec versions might work - eg an old version of JAX-RS or something? (check that that's a plausible/common problem though).

from guide-docker.

Kubik42 avatar Kubik42 commented on July 23, 2024

See #25

from guide-docker.

ebullient avatar ebullient commented on July 23, 2024

This has been sitting, but.. "My understanding is that users would want to learn about Docker and we teach them, but it just so happens that we use Open Liberty for it." -- I found the following really confusing:

# Start with OL runtime.
FROM open-liberty

# Symlink servers directory for easier mounts.
RUN ln -s /opt/ol/wlp/usr/servers /servers

# Run the server script and start the defaultServer by default.
ENTRYPOINT ["/opt/ol/wlp/bin/server", "run"]
CMD ["defaultServer"]

As far as this guide goes, the use of symlinks or volume mounts hasn't been mentioned at all, so the relevance of the symlink as a thing to do is dubious.

The ENTRYPOINT and CMD are a little off what the base liberty image does -- but it's pretty thin on what that means, etc.

I would simplify this to some of the main cases we have here: https://github.com/OpenLiberty/ci.docker/tree/master/openliberty/microProfile2/java8/ibmjava

Documentation matching w/ recommended examples (and enough context) is wonderful.

(the read-only stuff is good, but off-topic for docker guide, unless you want a whole subsection of the guide to talk about volume mounts .. but do it all together)

from guide-docker.

gkwan-ibm avatar gkwan-ibm commented on July 23, 2024

#74 will have a different development experience to develop application with docker container

from guide-docker.

gkwan-ibm avatar gkwan-ibm commented on July 23, 2024

close

  • the guide is using devc mode to develop application with docker container

from guide-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.