Giter Site home page Giter Site logo

Comments (5)

nick-delirium avatar nick-delirium commented on May 27, 2024

does this work fine outside localhost or via ngrok? Can you send an example of how the html should look like for that image

from openreplay.

Duck5el avatar Duck5el commented on May 27, 2024

It is running in staging and localhost environment.

HTML of not working image:

<div class="vueperslide__content-wrapper">
    <img src="https://cdn.expert.de/cdn-cgi/image/w=400,h=350,q=80,f=webp,fit=contain/ae/48/4e/c814b5c708fbf68b19f6472e55a724bd69/Abbildung_1508811.jpeg"
        alt="iPad 10.2 Zoll Wi-Fi 256GB Space Grau" data-nuxt-img=""
        sizes="(max-width: 640px) 50vw, (max-width: 768px) 25vw, 400px"
        srcset="https://cdn.expert.de/cdn-cgi/image/w=1,h=350,q=80,f=webp,fit=contain/ae/48/4e/c814b5c708fbf68b19f6472e55a724bd69/Abbildung_1508811.jpeg 1w, https://cdn.expert.de/cdn-cgi/image/w=160,h=350,q=80,f=webp,fit=contain/ae/48/4e/c814b5c708fbf68b19f6472e55a724bd69/Abbildung_1508811.jpeg 160w, https://cdn.expert.de/cdn-cgi/image/w=400,h=350,q=80,f=webp,fit=contain/ae/48/4e/c814b5c708fbf68b19f6472e55a724bd69/Abbildung_1508811.jpeg 400w"
        class="image-item" title="iPad 10.2 Zoll Wi-Fi 256GB Space Grau"><!---->
</div>

HTML of working image

<a href="/Viersen">
    <img src="https://cdn.expert.de/8e/14/13/ab0a5b6ea7d9e267601817aa9395a70200/logo_26344894.svg"
        onerror="this.setAttribute('data-error', 1)" alt="expert Viersen" data-nuxt-img=""
        srcset="https://cdn.expert.de/8e/14/13/ab0a5b6ea7d9e267601817aa9395a70200/logo_26344894.svg 1x"
        data-storeid="26344894" class="store-logo transition" id="storeInformation" title="expert Viersen"
        data-storename="expert Viersen">
</a>

from openreplay.

nick-delirium avatar nick-delirium commented on May 27, 2024

well, the issue is that you're using commas as query parameters, while the most usual/common way to use comma is to separate different urls for srcset, for example. We sadly have no way to distinguish urls and query params in srcset/src string with commas so it will not work unless you have idea how to fix current code without breaking it for users who use it rn (considering relative and absolute urls, space after comma and no space, etc)

from openreplay.

nick-delirium avatar nick-delirium commented on May 27, 2024

following #1962 testing beta version -> @openreplay/[email protected]

from openreplay.

nick-delirium avatar nick-delirium commented on May 27, 2024

merged and released as 12.0.5, please open a new issue in case of other problems

from openreplay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.