Jenkins parameters w/o any default value should not be unset

[openshift-eng]

Jenkins parameters w/o any default value should not be unset

[stevekuznetsov]

How do you think we should get around this? It's default Jenkins behavior AFAICT.

[0xmichalis]

Either https://wiki.jenkins.io/display/JENKINS/Export+Parameters+Plugin may work or we can query Jenkins params from inside which sounds meh.

[0xmichalis]

As a workaround for now, we can default to <none> (what I did in the new fork_ami job).

[0xmichalis]

or we can query Jenkins params from inside which sounds meh.

Hm, if we can't have the build id then this is not possible. Chicken-egg problem.

[stevekuznetsov]

What is a concrete example of this failure? When the job should either do the old flow (with $ORIGIN_PULL_ID) or the new one (with $PULL_REFS)? Why not just:

if [[ -n "${PULL_REFS:-}" ]]; then
    # run k8s-style stuff
elif [[ -n "${ORIGIN_PULL_ID:-}" ]]; then
    # run origin-style stuff
else
    # uh oh
fi

[0xmichalis]

If that won't break when PULL_REFS is unset, then it's fine.

[stevekuznetsov]

Yep, that is correct way to check for variables being set and will play nice with set -o errexit and set -o nounset.