Comments (3)
@eriknelson I think we can close this issue yes?
from ansible-service-broker.
I think it's better to validate the clients before we create the broker. It's a simple pre-flight check to make sure your environment is in order. I also think these checks could be added to the client package so we can reduce the size of app.go.
from ansible-service-broker.
I think it's better to validate the clients before we create the broker. It's a simple pre-flight check to make sure your environment is in order. I also think these checks could be added to the client package so we can reduce the size of app.go.
Agreed. When I was looking at refactoring things it seemed like there were a lot of blocks in App.Start
that were written to instantiate/init/validate indirectly by just creating references. Think those init's and checks should be behind a func named appropriately like InitAndValidate
called from App.Start
, and then we can get rid of all of the random inits and exit 1 if anything blows up.
from ansible-service-broker.
Related Issues (20)
- automation-broker-apb canary image hangs running tests sometimes HOT 13
- Loop in provisioning objects HOT 3
- k8s installation script does not longer exists HOT 7
- Helm registry adapter HTTP basic authentication HOT 7
- Unable to load secret on ASB HOT 4
- Future Release Branches Frozen For Merging | branch:release-4.5 branch:release-4.4
- No serviceInstance of Postgresql APB is created when running on kube 1.14 HOT 3
- apb/install.yaml does not exist anymore HOT 14
- Add possibility to declare secrets within the localregistry temporary projects. HOT 5
- Cannot install ansible-service-broker on kubernetes HOT 5
- Future Release Branches Frozen For Merging | branch:release-4.6 branch:release-4.5
- Broker fails to discover HELM charts if absolute URL is not present in index.yaml HOT 3
- Future Release Branches Frozen For Merging | branch:release-4.7 branch:release-4.6 HOT 2
- The service broker returned an invalid response for the request to https://broker.automation-broker.svc:1338/ansible-service-broker//v2/catalog HOT 2
- Broker reports : Unable to load secret 'afe58628-6998-444a-9ce4-584bec842e22' from namespace 'automation-broker' HOT 3
- Could not find instance 425596b8-7d39-4f94-b501-7b676491f203 associated with job state HOT 12
- Errors you may encounter when upgrading the library HOT 7
- Future Release Branches Frozen For Merging | branch:release-4.10 branch:release-4.9 HOT 4
- Status of this project? HOT 4
- Future Release Branches Frozen For Merging | branch:release-4.18 branch:release-4.19
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-service-broker.