Comments (7)
Maybe related to #3951, issue is not present when I set the image tags to v2.4.4
from assisted-service.
There is incomplete JSON data in the file;
This chunk of JSON at lines 205 - 208
{
"name": "multipathd.service",
"enabled": true, <---- notice the contents that should follow is missing
},
It should be amended to include the service's contents;
{
"name": "multipathd.service",
"enabled": true,
"contents": "bla bla bla". <---- notice the contents that should be placed here
},
@avishayt please fix the error introduced by commit;
73fd263
from assisted-service.
I'm guessing that this is because the ISO doesn't have multipathd installed? Please verify.
from assisted-service.
@avishayt
No, I'm suggesting the problem is to do with the internal/ignition/ignition.go code.
It is generating an ignition file that has invalid json. since the change in this commit
As I suggested in my earlier comment, shouldn't there be a contents element containing the service definition for the multipathd.service
from assisted-service.
This is strange because in OpenShift/RHCOS, it is working. I SSH into an agent and see:
[core@localhost ~]$ systemctl status multipathd
● multipathd.service - Device-Mapper Multipath Device Controller
Loaded: loaded (/usr/lib/systemd/system/multipathd.service; enabled; vendor preset: enabled)
Active: active (running) since Sun 2022-06-26 09:14:33 UTC; 3min 20s ago
Process: 1228 ExecStartPre=/sbin/multipath -A (code=exited, status=0/SUCCESS)
Process: 1226 ExecStartPre=/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac dm-multipath (code=exited, status=0/SUCCESS)
Main PID: 1230 (multipathd)
Status: "up"
Tasks: 7
Memory: 15.9M
CGroup: /system.slice/multipathd.service
└─1230 /sbin/multipathd -d -s
Jun 26 09:14:33 localhost systemd[1]: Starting Device-Mapper Multipath Device Controller...
Jun 26 09:14:33 localhost multipathd[1230]: --------start up--------
Jun 26 09:14:33 localhost multipathd[1230]: read /etc/multipath.conf
Jun 26 09:14:33 localhost multipathd[1230]: path checkers start up
Jun 26 09:14:33 localhost systemd[1]: Started Device-Mapper Multipath Device Controller.
[core@localhost ~]$ cat /etc/systemd/system/sysinit.target.wants/multipathd.service
[Unit]
Description=Device-Mapper Multipath Device Controller
Wants=systemd-udev-trigger.service systemd-udev-settle.service
Before=iscsi.service iscsid.service lvm2-activation-early.service
Before=local-fs-pre.target blk-availability.service shutdown.target
After=multipathd.socket systemd-udev-trigger.service systemd-udev-settle.service
ConditionPathExists=/etc/multipath.conf
DefaultDependencies=no
Conflicts=shutdown.target
ConditionKernelCommandLine=!nompath
ConditionKernelCommandLine=!multipath=off
[Service]
Type=notify
NotifyAccess=main
LimitCORE=infinity
ExecStartPre=-/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac dm-multipath
ExecStartPre=-/sbin/multipath -A
ExecStart=/sbin/multipathd -d -s
ExecReload=/sbin/multipathd reconfigure
TasksMax=infinity
[Install]
WantedBy=sysinit.target
Also=multipathd.socket
from assisted-service.
FCOS doesn't have multipath.service
pre-installed, but imo its an Ignition bug - it should not crash on enabling the service which doesn't exist, or at least give a better error message.
Seems we need to remove multipathd ignition part on OKD deployments (iirc it is being enabled with a flag)
from assisted-service.
That's what I suspected, thanks for verifying @vrutkovs . I'll add multipath to the ignition only if not OKD.
from assisted-service.
Related Issues (20)
- Documentation lacking for airgapped envs HOT 5
- Incorrect modes in the discovery.ign template HOT 2
- How to change the url for edge-infrastructure/assisted-installer-service-agent to local repo for disconnected sites?
- DNS validation fails but it's wrong HOT 7
- Future Release Branches Frozen For Merging | branch:release-ocm-2.8
- Support removed for rootless containers? HOT 3
- Inconsistencies possible between levels of assisted-install in hub and agent in discovery iso deployments HOT 6
- Future Release Branches Frozen For Merging | branch:release-ocm-2.9
- Hostprefix should not be required for non OpenshiftSDN / OVNkubernetes networktypes HOT 1
- Allow machine CIDR to be empty when having a Dual-stack cluster and userManagedNetworking: true HOT 1
- Future Release Branches Frozen For Merging | branch:release-ocm-2.10
- L2ConnectivityMajorityGroup is empty HOT 4
- skipper make all is failing HOT 1
- waiting for host
- "Copy to clipboard" button doesn't work after cluster installation HOT 5
- Future Release Branches Frozen For Merging | branch:release-ocm-2.12
- Support HTTPS URL for HTTPS_Proxy HOT 1
- Future Release Branches Frozen For Merging | branch:release-4.16 branch:release-4.17
- Dependency Dashboard
- Failed to import client/operators package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from assisted-service.