Giter Site home page Giter Site logo

Comments (5)

bparees avatar bparees commented on June 25, 2024

In addition to doing this, i'd like to change the api server behavior to default to image-registry.openshift-image-registry.svc.cluster.local:5000 so that when the apiserver comes up before the registry is installed, it still has the correct value.

The reason this is important is because the imagechangecontroller caches the values of the imagestreams it lists, and the imagestream list/get api uses a decorator to apply the status.dockerImageRepository value based on the internalHostname.

The overall impact of which is that if the imagechangecontroller is up before the registry configuration is available, it will cache values that have an empty status.dockerImageRepository and even after the registry comes up, it will use the incorrect value.

Also of course once we start publishing this information, we need the api server to consume it.

from cluster-image-registry-operator.

legionus avatar legionus commented on June 25, 2024

@dmage Is this still relevant?

from cluster-image-registry-operator.

bparees avatar bparees commented on June 25, 2024

Yes, some of this will be part of my work this sprint: the image-registry operator will need to publish the internalRegistryHostname value into the cluster configuration so it can be consumed by the apisever and controllers (previously those components got the value from master-config.yaml).

and I have a PR for defaulting the value in some of the components themselves here, but i'm not sure it's going to go anywhere: openshift/origin#21160

from cluster-image-registry-operator.

bparees avatar bparees commented on June 25, 2024

we're now publishing this information (internalhostname anyway) to the image clusterconfig object.

the default hostname should be published there as well, when it is defined.

from cluster-image-registry-operator.

dmage avatar dmage commented on June 25, 2024

We publish information about all known hostnames to the image.config object.

from cluster-image-registry-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.