template-lint.sh can't handle committed file renames

[openshift]

template-lint.sh can't handle committed file renames

[sgreene570]

Suspect git log call here:
https://github.com/openshift/enhancements/blob/master/hack/template-lint.sh#L15-L17

[dhellmann]

@sgreene570 I wasn't able to reproduce the problem you reported using the steps given. Can you try #785 to see if that helps?

[dhellmann]

/assign

[sgreene570]

@sgreene570 I wasn't able to reproduce the problem you reported using the steps given. Can you try #785 to see if that helps?

#785 does the trick for me! Thanks.

[dhellmann]

I'm curious to know what leads to the different behavior. Which version of git do you have?

[sgreene570]

I'm curious to know what leads to the different behavior. Which version of git do you have?

[sgreene@snowplow:~]$ git version
git version 2.31.1
[sgreene@snowplow:~]$ echo $BASH_VERSION
echo $BASH_VERSION
5.0.17(1)-release
[sgreene@snowplow:~]$ cat /etc/os-release 
NAME=Fedora
VERSION="33 (Server Edition)"
ID=fedora
VERSION_ID=33
VERSION_CODENAME=""
PLATFORM_ID="platform:f33"
PRETTY_NAME="Fedora 33 (Server Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:33"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f33/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=33
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=33
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Server Edition"
VARIANT_ID=server
[sgreene@snowplow:~]$ uname -r
5.11.18-200.fc33.x86_64

[sgreene570]

Maybe something is different between our linter images? I am able to reproduce this issue with my simple reproducer with a linter image built off of master 🤔

[dhellmann]

You have a newer git version on Fedora than I do on CentOS (2.27.0). I wonder if the newer version is recording or reporting the metadata for changes in a different ways.

[sgreene570]

I wonder if the newer version is recording or reporting the metadata for changes in a different ways.

Git 2.31.0 was denoted as a backwards incompatible release, so this is entirely possible.

[sgreene570]

Closing issue since #785 has merged.
Feel free to revive if there's more to dig into here.