Giter Site home page Giter Site logo

Comments (6)

diego-garro avatar diego-garro commented on July 28, 2024 2

Ok guys

from defrag-api.

why-not-try-calmer avatar why-not-try-calmer commented on July 28, 2024

Hello deigo, it's always a good idea to use a code formatter. My favorite one is autopep8, because it's very close to the official recommended formatting. I think the end result is not very different from black. In a big, industrial project it would be certainly not doable to work with different formatters, but here I think it's OK if everyone picks their favorite formatter. As you will see if it's not already the case, we have a very modular approach, so if you maintain a module, you get to pick the formatter for it, I guess.

I don't know what @KaratekHD prefers, but I don't mind letting people choose what they want because it's very personal at the end.

from defrag-api.

diego-garro avatar diego-garro commented on July 28, 2024

Exactly, the idea is that everyone uses the same formatter, so it will be added to requirements.txt and automatically installed.

from defrag-api.

why-not-try-calmer avatar why-not-try-calmer commented on July 28, 2024

Exactly, the idea is that everyone uses the same formatter, so it will be added to requirements.txt and automatically installed.

What I meant is that for me it's better if every one chooses the formatter they prefer for the modules they maintain, that is, 1 formatter for 1 module, but perhaps 4 different formatters in total.

from defrag-api.

KaratekHD avatar KaratekHD commented on July 28, 2024

I didn't use a code formatter before, but for this project I use autopep8. But I think it's ok if everyone choses what they like, like @why-not-try-calmer suggested.

from defrag-api.

why-not-try-calmer avatar why-not-try-calmer commented on July 28, 2024

Nice. So @diego-garro the idea is not:

  • let's make the code base a happy mess

the idea is:

  1. the person "responsible" (doing the more work on) module A uses the formatter they want for A.
  2. the same person never uses different formatters.

When/if we have 5+ people working a lot with 5+ different formatters, this will not work anymore. But for now it's OK

from defrag-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.