Process execution sometimes fails on ppc64le and s390x

[opensuse]

Process execution sometimes fails on ppc64le and s390x

[AdamWill]

Annoyingly, if I isolate the relevant code into a test script and run it over and over on a ppc64le box (a different one - one of our worker boxes, since I don't have shell access to the package build hosts), it works fine every time. Sigh.

[AdamWill]

@cfconrad

[cfconrad]

Yeah I think you are right. This is also a race in Mojo-IOLoop-ReadWriteProcess with short executed commands.
Currently I have no idea to solve them.

There is a race in fork/open and session->register($pid). If the later is called after the process is already finished (collected by collected_orphan), then we get that error.

It's actually really easy to reproduce, I get it just by calling:

perl <<'EOT'
use Mojo::Base -strict;
use Mojo::IOLoop::ReadWriteProcess 'process';
say process(execute => '/usr/bin/true')->quirkiness(1)->start()->wait_stop()->exit_status();
EOT

If you don't get it, you could produce this race by adding a sleep in here: https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess/blob/master/lib/Mojo/IOLoop/ReadWriteProcess.pm#L482

[cfconrad]

I only found this workaround... let's see what others think.

[foursixnine]

This is fixed by #22

[AdamWill]

awesome, thanks.