Comments (7)
Postponing to 1.2
from opentk.
Started making some progress on this in my fork, very hardcoded at the moment but wraps around OpenGL calls.
from opentk.
Awesome, thanks for looking into this!
The previous implementation used the following hard-coded rules:
- Every call is surrounded by
using (new ErrorHelper(GraphicsContext.CurrentContext)) { /* actual call */ }
GL.GetError()
is not surrounded, as that would cause infinite recursion.GL.Begin()
setsGraphicsContext.CurrentContext.ErrorChecking = false;
before the OpenGL call.GL.End()
setsGraphicsContext.CurrentContext.ErrorChecking = true;
after the OpenGL call.
The reason for 3 and 4 is that it is an error to call GL.GetError()
inside a begin-end region, so ErrorChecking = false
temporarily turns off error checking.
The original generated code is available here (warning, large file).
from opentk.
Would like someone to just double check the code, it probably needs a cleanup but it's functional. https://github.com/Frassle/opentk/tree/develop
Also should I rewrite history before pull request?
from opentk.
Please rebase against opentk/develop before issuing the PR. I'll double check the code to make sure it works as expected on .Net and Mono.
from opentk.
OK, I'm going to make some final tidy ups and get to to work for other namespaces not just OpenTK.OpenGL then I'll submit the pull request.
from opentk.
This is now merged.
from opentk.
Related Issues (20)
- [Open TK 4] Platform Detection issue for Android (& IOS?) HOT 5
- WindowState Fullscreen issues in 4.8.1
- Expose GLFWCallbacks.FramebufferSizeCallback through NativeWindow.
- Mouse movement using significant CPU time HOT 2
- Contributor suggestions HOT 2
- Setting CurrentMonitor switches display to 800x600 HOT 8
- [5.0] Fix WGL and GLX bindings using GLLoader
- Move OpenTK.Color3 to OpenTK.Mathematics.Color3
- [5.0] Fix NativeWindow and AutoLoadBindings HOT 2
- [5.x] Locale bug in bindings generator capitilization HOT 1
- [PAL2] Fix mouse up event when releasing mouse outside of window HOT 1
- Switch from PackageIconUrl to PackageIcon HOT 1
- Backport OpenTK 5 build system to OpenTK 4
- MathF or Math? (Matrix4.cs) HOT 2
- No TargetFrameworks set in Nuget Package HOT 4
- Unable to load openal library when built with nativeaot targeting android HOT 3
- [PAL2] PAL 2 Todo list
- Add support for OpenGL ES 3.2 HOT 4
- OpenTK.OpenAL 4.8.1 not present on nuget.org HOT 3
- replace all "ref" statement for "in" instead HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentk.