Idle voice announcements are played even though they are deactivated in settings

[bneuburg]

Idle voice announcements are played even though they are deactivated in settings

[bneuburg]

@dennisguse I can try to fix it if you can give me a pointer where to do that, I haven't tinkered with Android apps yet.

After looking around I suspect the problem is in settings_announcments.xml

    <PreferenceCategory android:title="@string/settings_announcements_idle_category_title">
        <SwitchPreferenceCompat
            android:defaultValue="@bool/voice_announce_total_distance_default"
            android:key="@string/voice_announce_total_distance_key"
            android:title="@string/settings_announcements_idle_title" />
    </PreferenceCategory>

That should probably be

    <PreferenceCategory android:title="@string/settings_announcements_idle_category_title">
        <SwitchPreferenceCompat
            android:defaultValue="@bool/voice_announce_idle_default"
            android:key="@string/voice_announce_idle_key"
            android:title="@string/settings_announcements_idle_title" />
    </PreferenceCategory>

[dennisguse]

Seems I messed up the preference config.
Could you fix that?

[pitastrudl]

Can confirm this bug with 4.9.3 from fdroid. Was recording my tracks for the whole week and had no idea where the sound was coming from, it seemed very random. I saw the idle announcment was enabled even though i never enabled it.

[dennisguse]

@bneuburg that seems to be the solution.
Can you create a PR for this?

[bneuburg]

@dennisguse Done

[dennisguse]

Closed by #1751.

@bneuburg Thanks :D