Giter Site home page Giter Site logo

optional chart fill about opentracks HOT 4 CLOSED

hercek avatar hercek commented on June 8, 2024
optional chart fill

from opentracks.

Comments (4)

dennisguse avatar dennisguse commented on June 8, 2024

👍
Can you share a screenshot how it looks like?

from opentracks.

hercek avatar hercek commented on June 8, 2024

Ok, here are some samples. The older version does not contain also the accepted PR which moves x-axis label lower right. So the comparison is not 100% fair. But I do not have only one commit older APK ready.

Portrait mode with chart fill
PortraitWithFill

Portrait mode without chart fill
PortraitNoFill

Landscape mode with chart fill
LandscapeWithFill

Landscape mode without chart fill
LandscapeNoFill

I think the problem is best visible in the landscape mode: try to follow the power curve in the interval from 4.2 km to 4.5 km (around the 3rd pin). It is more or less impossible in the version with the chart fill. Or I'm pretty much blind in my advanced age :)

Please specify whether you want version controlled by an option or just removing the fill all the time. Maybe it could be done with a 3-state checkbox - the 3-rd state would use fill for charts with only one or two data series.

from opentracks.

dennisguse avatar dennisguse commented on June 8, 2024

Looks good!
I would skip an additional setting and hide the fill if at least three data series are shown.
Does this make sense?

from opentracks.

hercek avatar hercek commented on June 8, 2024

Yes. I'll make a PR for this version: hiding fill when there are at least 3 data series visible.

from opentracks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.