patch: hardcoded speech + bad enclosure assumptions

[openvoiceos]

patch: hardcoded speech + bad enclosure assumptions

[ChanceNCounter]

Is the TODO on enclosure.base.py:74 blocking?

[ChanceNCounter]

Hardcoded timeout on 133 may be objectionable.

[AIIX]

Testing the patch still reports the "mycroft.skills.trained" message on bus to early even on first boot

[ChanceNCounter]

Probably good to log (or at least print) status during that while loop, as it's in a core component and could cause Mycroft to (effectively) hang quietly.

[JarbasAl]

MycroftAI/mycroft-core@dev...OpenVoiceOS:refactor/enclosure_assumptions

should account for pairing now before reporting ready

[JarbasAl]

Hardcoded timeout on 133 may be objectionable.

that TODO comes from mycroft, its not blocking and is in general a safe assumption, anyway @j1nx can enforce that skills only boots after enclosure i think

[j1nx]

Not really sure about that, but will investigate.

edit: read that wrong. Indeed but depends on the systemd notify patch we have planned. For now indeed i can make the skills service only start after starting enclosure first.

[j1nx]

Systemd / Notifyd is implemented. Closing this one as the enclosure assumption patch is no longer valid with mycroft-lib.