Giter Site home page Giter Site logo

Maybe stop using 7z about john-packages HOT 8 CLOSED

openwall avatar openwall commented on June 26, 2024
Maybe stop using 7z

from john-packages.

Comments (8)

claudioandre-br avatar claudioandre-br commented on June 26, 2024

We should make users happy, but I'm afraid the zip format is simple and ineffective.

7z a -mfb=258 -mpass=15 -r winX64_1_JtR.zip JtR/
# versus
7z a -t7z -m0=lzma -mx=9 -mfb=64 -md=128m -ms=on winX64_1_JtR.7z JtR/
$ ls -lh
total 101M
drwxrwxrwx 5 vscode vscode 4.0K Apr  7 15:11 JtR
-rw-r--r-- 1 vscode vscode  29M Apr 14 21:07 winX64_1_JtR.7z
-rw-r--r-- 1 vscode vscode  72M Apr 14 21:05 winX64_1_JtR.zip

In this case, should we educate people or give up and deliver a zip?

from john-packages.

solardiz avatar solardiz commented on June 26, 2024

Someone may be aware of the size difference, yet prefer a zip not to have to separately download and verify authenticity of (how?) and take the risk of using 7zip. I think zip is supported on Windows out of the box now, isn't it? Perhaps ditto on macOS.

BTW, here are the commands I wrote down from when I released 1.9.0-jumbo-1:

V=1.9.0-jumbo-1
chmod -R go-rwx john-$V
tar cvJf john-$V.tar.xz --owner=root --group=root `find john-$V ! -type d | sort -i -t / -k 3 | sort -i -t . -k 3`
xzcat john-$V.tar.xz | pigz -11 > john-$V.tar.gz

rm ../doc/README
find ../doc ../run/rules -type f -exec sed -i -e 's/\r*$/\r/' {} ';'
sed -i -e 's/\r*$/\r/' ../README.md ../run/*.conf ../run/password.lst
find ../doc -type f -not -name '*.txt' -not -name '*.md' -exec mv -v '{}' '{}'.txt \;

7za a -t7z -m0=lzma -mx=9 -mfb=64 -md=128m -ms=on john-1.9.0-jumbo-1-win32.7z john-1.9.0-jumbo-1-win32
7za a -t7z -m0=lzma -mx=9 -mfb=64 -md=128m -ms=on john-1.9.0-jumbo-1-win64.7z john-1.9.0-jumbo-1-win64

7za a -tzip -mx=9 john-1.9.0-jumbo-1-win32.zip john-1.9.0-jumbo-1-win32
7za a -tzip -mx=9 john-1.9.0-jumbo-1-win64.zip john-1.9.0-jumbo-1-win64

from john-packages.

claudioandre-br avatar claudioandre-br commented on June 26, 2024

[edited]

The final result is:

  • flatpak bundle is, well, already a bundle (no real compression). No need to have a .7z file;
  • is a tar file needed? IMO, zip is fine.
  • let's see what people do and stop providing the 7z if no one uses it.

image

from john-packages.

solardiz avatar solardiz commented on June 26, 2024

Thank you, @claudioandre-br!

let's see what people do and stop providing the 7z if no one uses it.

How would we know?

from john-packages.

claudioandre-br avatar claudioandre-br commented on June 26, 2024

We can use the release statistics. GitHub has an API for it; easy to get data from it.


And, well, users are welcome to interact with us.

from john-packages.

solardiz avatar solardiz commented on June 26, 2024

I've just checked our web server logs for recent 1.9.0-jumbo-1 Win64 downloads in ZIP vs. 7z. These are at 57% for ZIP vs. 43% for 7z (percentages out of their combined total, which includes some duplicate downloads by the same people). So both formats are popular (but ZIP is more popular even despite of the larger size), and I think we should keep both. These percentages are for full size one-shot downloads (HTTP code 200 with the full file size), but I am getting similar percentages for steps in partial downloads (HTTP code 206) even though I'd have expected their number to be inflated more by ZIP's larger size. Edit: also got similar percentages (55% ZIP, 45% 7z) for another (non-overlapping) time period.

from john-packages.

github-actions avatar github-actions commented on June 26, 2024

This issue is stale because it has been open for 14 days with no activity.

from john-packages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.