Automatically configure DEFAULT_FROM_EMAIL

[openwisp]

Automatically configure DEFAULT_FROM_EMAIL

[R9295]

I'll be working on this issue

[R9295]

What could be a good default value? "[email protected]"?

[nemesifier]

something like openwisp2@{{ inventory_hostname }}, but I don't know what would happen in case {{ inventory_hostname }} would be an ip address.

We should add this new variable to the list of available variables but I think we should also highly suggest to set it manually in the playbook by updating our examples in the README to mention this.

Why we need to do this? Because as soon as people start using openwisp2 in a production environment, the system will try to send emails when new users are created or a password is reset, but if not configured correctly either the email won't be sent or the system may crash entirely so we gradually have to fix each case until we have good defaults that work in most cases without too much user intervention.

[R9295]

What could be a good way to explain it in the README? I'm thinking something along these lines:
"It is recommended that you change the value of this variable if you intend to use OpenWISP2 in production, as a misconfiguration may result in emails not being sent "

[nemesifier]

Yes that's fine, I think I also replied via chat so you should be ready to go, we'll improve during the review also so don't worry.