Configurable sample rate

[openzipkin]

Configurable sample rate

[codefromthecrypt]

unlike sleuth, this project doesn't assume a specific configuration library. So, when you configure the library, you'd choose how to specify things like the sample rate. Example of wiring up is here:

https://github.com/openzipkin/zipkin-js/tree/master/packages/zipkin

Moving forward, I don't know what the status quo configuration tools are for browser or node apps. It may be the case that such libraries will turn-up, similar to how dropwizard-zipkin was made in java to bind dropwizard-style config on top of brave.

[huanli2]

I found the example have something wrong when i try to use it to set the sample rate for my project.
1,new zipkin.CountingSampler(0.01) should be new zipkin.sampler.CountingSampler(0.01)
2,missing two ","

[codefromthecrypt]

thanks, do you mind fixing it? (raise a pull request by editing the incorrect file)

[huanli2]

pull request:
#77

actually, when I debug into the tracer code, and the sample rate can print correctly, but this configuration doesn't work with my express + zipkin-instrumentation-express.

"It may be the case that such libraries will turn-up, similar to how dropwizard-zipkin was made in java to bind dropwizard-style config on top of brave." do you have a release date or have a plan to fix it?

[nickcodefresh]

Thanks guys, works a treat