Comments (10)
Hi,
I completed a Pull request to make the changes but it went to staging. Is that the branch you will like to see the request submitted to? I will like to help and not sure if I did the right thing.
Thank you.
from operationcode-pybot.
Yes, staging is correct. For this particular repo, we like to test it out in a staging environment before deploying. I believe there's CI/CD set up to automatically deploy to production when it's merged to master, so we have PRs go to staging as a stop-gap
from operationcode-pybot.
Also, we don't generally merge our own PRs around here, it probably would have been a good idea to wait for either myself or @AllenAnthes to review it before merging it to staging
from operationcode-pybot.
Ah, I just looked at your PR a little closer. You'll want to open one against the main repo (i.e., https://github.com/OperationCode/operationcode-pybot). It looks like you opened it up against your fork (https://github.com/Adeola-Adesoba/operationcode-pybot).
If you need some help opening up a PR, let me know and we can get you squared away
from operationcode-pybot.
Oh, I see. Thank you for taking the time review it.
Let me make the changes. I can make a PR but it will great to still get some help from you.
from operationcode-pybot.
Are you on our slack team @Adeola-Adesoba? If so, message me (I'm @Raz0r
on there). If not, sign up at https://operationcode.org/join and we can set aside some time for a slack call and we can go over some of the finer points 😄
from operationcode-pybot.
Ok, I will sign up. I am already on it though. I realized what you meant by "It looks like you opened it up against your fork (https://github.com/Adeola-Adesoba/operationcode-pybot)." I will make a PR soon. Thank you.
from operationcode-pybot.
This worked right?
from operationcode-pybot.
Yup, the new PR is in the right place, thanks! We'll take a look and let you know if anything needs to change before we merge, but it looks good to me so far
from operationcode-pybot.
Thank you Aaron.
from operationcode-pybot.
Related Issues (20)
- daily-programmer pin manager bot HOT 9
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
- Remove /ticket command HOT 2
- Slack Invite Error should go to Ops channel instead of moderator channel HOT 1
- Inheriting 'MutableMapping', which is not a class. HOT 3
- Link to new form for `/mentor-volunteer`
- OC-pybot Welcome Message HOT 6
- Add "Intro to Slack" video to pop up on Slackbot HOT 1
- Add FAQ to OC Pybot HOT 2
- acknowledgement for /report command HOT 2
- Automatic Response for Mentor Requests HOT 1
- New Commands for Support Channels HOT 4
- Mentor Bot Message Thread Improvements HOT 1
- Requestor Affiliation broken HOT 1
- Rewrite - Change the logging behavior to log to Cloudwatch HOT 1
- Rewrite - Switch to Github Actions Instead of CircleCI HOT 2
- Rewrite - Ensure the bot is handling sending invites to users for Slack
- Rewrite - Ensure we handle message changed and message deleted events HOT 1
- Add in `/moderators` command that will list the current moderators
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from operationcode-pybot.