Giter Site home page Giter Site logo

Comments (10)

Adeola-Adesoba avatar Adeola-Adesoba commented on June 5, 2024

Hi,
I completed a Pull request to make the changes but it went to staging. Is that the branch you will like to see the request submitted to? I will like to help and not sure if I did the right thing.

Thank you.

from operationcode-pybot.

aaron-junot avatar aaron-junot commented on June 5, 2024

Yes, staging is correct. For this particular repo, we like to test it out in a staging environment before deploying. I believe there's CI/CD set up to automatically deploy to production when it's merged to master, so we have PRs go to staging as a stop-gap

from operationcode-pybot.

aaron-junot avatar aaron-junot commented on June 5, 2024

Also, we don't generally merge our own PRs around here, it probably would have been a good idea to wait for either myself or @AllenAnthes to review it before merging it to staging

from operationcode-pybot.

aaron-junot avatar aaron-junot commented on June 5, 2024

Ah, I just looked at your PR a little closer. You'll want to open one against the main repo (i.e., https://github.com/OperationCode/operationcode-pybot). It looks like you opened it up against your fork (https://github.com/Adeola-Adesoba/operationcode-pybot).

If you need some help opening up a PR, let me know and we can get you squared away

from operationcode-pybot.

Adeola-Adesoba avatar Adeola-Adesoba commented on June 5, 2024

Oh, I see. Thank you for taking the time review it.

Let me make the changes. I can make a PR but it will great to still get some help from you.

from operationcode-pybot.

aaron-junot avatar aaron-junot commented on June 5, 2024

Are you on our slack team @Adeola-Adesoba? If so, message me (I'm @Raz0r on there). If not, sign up at https://operationcode.org/join and we can set aside some time for a slack call and we can go over some of the finer points 😄

from operationcode-pybot.

Adeola-Adesoba avatar Adeola-Adesoba commented on June 5, 2024

Ok, I will sign up. I am already on it though. I realized what you meant by "It looks like you opened it up against your fork (https://github.com/Adeola-Adesoba/operationcode-pybot)." I will make a PR soon. Thank you.

from operationcode-pybot.

Adeola-Adesoba avatar Adeola-Adesoba commented on June 5, 2024

This worked right?

from operationcode-pybot.

aaron-junot avatar aaron-junot commented on June 5, 2024

Yup, the new PR is in the right place, thanks! We'll take a look and let you know if anything needs to change before we merge, but it looks good to me so far

from operationcode-pybot.

Adeola-Adesoba avatar Adeola-Adesoba commented on June 5, 2024

Thank you Aaron.

from operationcode-pybot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.