Comments (3)
@ryantking wdyt? Could you give us a hand with this one?
c/c @gallettilance
from api.
I'm not sure it makes sense to do this for the entire version string. All kubernetes resource names have a set of character and length restrictions that make them incompatible with semver strings. See:
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
Compare that to the semver spec, for example build metadata which includes +
characters: https://semver.org/#spec-item-10 and there's already an obvious incompatibility.
In general, the convention operators have been following has been:
$operatorname.v.$majorversion.$minorversion.$patchversion
I think it could make sense to parse the csv metadata.name
and pull the major minor and patch versions, and ensure that those match, but this is still mostly for the purpose of UX and information, so I don't think we should restrict the spec.version of csvs from the current allowable values -- today that looks like anything that conforms to the semver spec.
from api.
It shows for me that what we can do here is check if the v.$majorversion.$minorversion.$patchversion
when present matches with the CSV.spec version and provides warnings when not. That would fit well in the Good Practices Validator when we check if the Operator Bundle name follows the convention $operatorname.v.$majorversion.$minorversion.$patchversion
.
Note that the PR: #238 shows block this one.
from api.
Related Issues (20)
- Improve API documentation for CSV and PackageManifest HOT 2
- Add common linter check to ensure that all operator/managers defined the resource request HOT 3
- Add package manifest apis HOT 3
- Remove go-get usage from Makefile in preparation of Go 1.18 HOT 2
- CSV Validation should check `spec.version` and `metadata.annotations.skipRange` HOT 2
- Begin to check the size of each bundle file into bundle size checker to ensure that all are not bigger than ~1MB HOT 1
- ClusterServiceVersionValidator is not raising errors when the annotations are duplicated HOT 3
- [Validators] - Review and improve warn/error message in order to provide how to sort them out HOT 1
- Is there a reason that we're not using the regex from [semver](https://semver.org/)?
- The multiarch validator should not warning when only linux.amd64 platform is found HOT 1
- CSVValidator does not fail on invalid env in deployment spec
- Bump Go version to 1.18 HOT 1
- Catalog source poll is not required if the image refers to a digest
- Bump the yq tool dependency from v3 to v4 HOT 1
- Converting an operator group object to an unstructured object causes a panic HOT 1
- Serializing Subscription resources without including "status" field?
- Godoc missing from Subscription API
- RFE: good practices validator only warn for empty CRD desc if spec.customresourcedefinitions in csv is not empty
- Enhance partial explanations on `catalogsource.status`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api.