Giter Site home page Giter Site logo

Comments (5)

mikewied avatar mikewied commented on August 16, 2024

This issue blocks #139. I haven't looked into dynamic client pools, but it looks like once you create the client pool the any CRD's registered after the operator starts won't be available to the sdkclient API's.

from operator-sdk.

ericchiang avatar ericchiang commented on August 16, 2024

cc @rithujohn191

from operator-sdk.

CSdread avatar CSdread commented on August 16, 2024

@hasbro17 @ericchiang is this PR in the direction you were thinking, i want to verify that it is the right direction and i will complete it and add unit tests.

CSdread#1

from operator-sdk.

hasbro17 avatar hasbro17 commented on August 16, 2024

@CSdread I would hold off on that for now. Your PR is in the right direction but there's more to it than just making it a package level singleton.
The client is also used by the Watch API to create the informers which has it's own global state. So we're currently redesigning the sdk.Watch API into a controller package and the client will have to be part of that so it can be exposed to the handler. I will update this issue with more context on that once we have something more concrete on that front.

from operator-sdk.

hasbro17 avatar hasbro17 commented on August 16, 2024

With #382 and the controller-runtime objects we don't have any implicit pkg level state backing global functions(for the client) anymore.

from operator-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.