Giter Site home page Giter Site logo

remove dune-control support about opm-common HOT 7 CLOSED

opm avatar opm commented on July 24, 2024
remove dune-control support

from opm-common.

Comments (7)

dr-robertk avatar dr-robertk commented on July 24, 2024

@akva2: Ok. But only if the sibling stuff goes too. I'm using dune-control and to that date it works fine and is the only way that works to build the OPM modules. I'm pretty sure that when I follow the instructions on the OPM web site, that I won't be able to build OPM. Until then, let's keep it.

from opm-common.

bska avatar bska commented on July 24, 2024

I'm using dune-control and to that date it works fine and is the only way that works to build the OPM modules.

That statement is not true--at least not literally. I'm building all of OPM in many different configurations and I don't use dunecontrol.

from opm-common.

atgeirr avatar atgeirr commented on July 24, 2024

But only if the sibling stuff goes too.

Please don't take hostages...

Dune-control support and sibling builds will remain for the time being since we have not yet reached a consensus about a single proper way to build.

I'm pretty sure that when I follow the instructions on the OPM web site, that I won't be able to build OPM

That has (unfortunately) been true since we introduced opm-cmake. However they have been tested (by people here coming into the project) successfully a few times. I will update the instructions when opm-common is ready.

from opm-common.

andlaus avatar andlaus commented on July 24, 2024

I'm using dunecontrol all the time. I would not mind if support for it was removed though, if I had an adequate alternative to rebuild everything with different options in one go.

from opm-common.

dr-robertk avatar dr-robertk commented on July 24, 2024

I investigated this topic a bit and it turns out that everything works fine when DuneCompat.cmake is removed (DUNE 2.4 with cmake). The configure script in cmake/Scripts is not needed anymore, because dunecontrol calls cmake directly and also not need is the DuneCompat2.cmake. There is a minor issue in dunecontrol that is being fixed as we "speak".

The only problem I see, is, that this would require to use the latest release version, DUNE version 2.4. But it might take the OPM community another decade or so to upgrade to 2.4.....

from opm-common.

atgeirr avatar atgeirr commented on July 24, 2024

The only problem I see, is, that this would require to use the latest release version, DUNE version 2.4. But it might take the OPM community another decade or so to upgrade to 2.4.....

I don't think so: we can probably leapfrog to 2.4 at some point instead of going through 2.3. @alfbr?

from opm-common.

atgeirr avatar atgeirr commented on July 24, 2024

Dune-control support and sibling builds will remain for the time being since we have not yet reached a consensus about a single proper way to build.

This I said a while ago, and I will therefore close this issue. However:

I investigated this topic a bit and it turns out that everything works fine when DuneCompat.cmake is removed (DUNE 2.4 with cmake). The configure script in cmake/Scripts is not needed anymore, because dunecontrol calls cmake directly and also not need is the DuneCompat2.cmake. There is a minor issue in dunecontrol that is being fixed as we "speak".

Therefore: when we are on Dune 2.4 we should revisit and simplify a bit (removing the configure script etc.), but for now this is a non-issue.

from opm-common.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.