Comments (8)
And why does dune/grid/CpGrid.hpp #include PersistentContainer at the very end; there doesn't seem to be any need for it?
from opm-grid.
It seems like the PersistentContainer class is not considered an official interface by the dune guys:
http://lists.dune-project.org/pipermail/dune/2013-February/012208.html
why it is in dune-cornerpoint I cannot say, as this seems to be only needed for adaptive grids. I've opened a PR to remove it, but maybe @atgeirr or @bska can enlighten us a bit more.
from opm-grid.
why it [the
PersistentContainer
] is in dune-cornerpoint I cannot say
The PersistentContainer
for class CpGrid
originated as contributed code (commit 0037c5d) to enable using CpGrid
with the third-party (meta-grid) manager "dune-parallelgrid". Whether or not the class is actually needed or if we should continue to carry or support that interface is a question of policy. I will note, though, that according to Robert Klöfkorn (author of dune-parallelgrid), the CpGrid
was (at the time of submission) among the most efficient grids available for use with dune-parallelgrid.
@atgeirr: Do you recall any additional details?
from opm-grid.
OK, I see; they changed the interface (between 2.2 and 2.3) in an incompatible way (removed the Allocator parameter), and we're trying to follow suite.
from opm-grid.
Alright. Its better to keep this class, then?
from opm-grid.
(in this case, can somebody with access to 'parallelgrid' verify that it still works? I don't have access to that project...)
from opm-grid.
I think it may be better to keep the class, and I am pretty sure updating it would be the good. However, have we solved the "how to interface with different dune versions" problem?
About the current state of dune-parallelgrid I am not quite sure, it's been some time since last I experimented with it.
from opm-grid.
However, have we solved the "how to interface with different dune versions" problem?
Yes, to a large extent I think we have, but of course if you mix versions of DUNE, havoc will probably ensue.
from opm-grid.
Related Issues (20)
- dune-istl is required rather than a suggestion
- PolyhedralGrid broken with dune-grid master
- How to run this module? HOT 1
- Question about conditionals in MinpvProcessor::process HOT 1
- Segmentation fault with MPI occuring in opm-grid/opm/grid/common/WellConnections.cpp HOT 10
- Parallel running gets stuck with the following error message HOT 12
- BuildFaceToCell Calling EntityRep::setValue() With Index of "-1" HOT 1
- Report on MINPV processing HOT 1
- Official Debian Packages HOT 1
- Please deactivate aquifer processing if no aquifer is there. HOT 1
- Configuring fails with 'Target ... links to target "TBB::tbb" but the target was not found' HOT 7
- Dune bug?? HOT 5
- Problem compiling opm-grid on Arch Linux HOT 4
- Errors in installing OPM modules HOT 3
- Not able to configure whth USE_MPI=OFF : Target "opmgrid" links to target "MPI::MPI_C" but the target was not found. HOT 2
- The master branch building failed with DUNE-2.6? HOT 2
- Using opm-grid as dune-module fails during CMake HOT 6
- Clang Compile errors in opm-grid HOT 1
- Parallel CpGrid test with aquifer cells is missing. HOT 3
- Issue with global_cell_ for PolyhedralGrid HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opm-grid.