Giter Site home page Giter Site logo

Comments (1)

BenHenning avatar BenHenning commented on July 17, 2024

So I've been working on addressing this. While the changes aren't yet final, I think my work will cover all of the following:

  • Introducing a new ClassroomRecord to include the topic dependencies graph & other classroom information.
  • Remove TopicIdList in favor of the above.
  • Updating TopicController and TopicListController to use this dependency graph, and to assume exactly one classroom by default (to load the list of topic IDs).
  • Updating the JSON loading pipeline & affected tests, where needed, to load correctly.
  • Update the download asset script to include:
    • A proper GAE DTO for classroom data.
    • A v2 representation (as part of oppia-proto-api) that correctly encapsulates classroom changes and topic dependencies (this is a WIP and not yet pushed).
    • Correct conversion to the new v1 protos being introduced in the Oppia Android proto folder (see above).

What's NOT being included:

  • Localization work for classroom data (the structures are being added for v2 for correctness, but nothing extra is being done for v1 objects).
  • Classroom-specific tests for the topic loading pipeline.

Note also that the topic dependency graph for test topics will be hardcoded in the script as we don't yet have a way to load them from a local instance of Oppia web (though this is a long-term plan).

The above should remove any need to make changes to the download script, ensure a working app version with classroom data, and remove a pretty large chunk of the classroom changes in the domain and data layers (but not all of it).

from oppia-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.