password.reset.response needs cleanup

[stuartpb]

password.reset.response needs cleanup

[stuartpb]

Also needing cleanup: password.reset.token.login. I think a lot of sites say "yes" when they should say "before" or "after", and I think I may have put an "after" value on something to mean "it presents you with a login form afterward" (which should probably get a distinct value, like "reenter").

[stuartpb]

How login forms are presented after changing password should really be part of the new usability profiles (#15). password.reset.token.login should just be for describing token login behavior.

[stuartpb]

Okay, so I just reviewed all the instances of password.reset.token.login, and none of them have a value of "yes", so that's not an issue. There are still more than a few "after" values that may have been referring to the kind of post-submit-login-form-dump covered by #38, which should be reviewed:

• 37signals.com
• bountysource.com
• name.com
• persona.org
• slides.com
• wikimedia.org

As for instances where password.reset.response.body is "token" that also need to be reviewed:

• gog.com
• okcupid.com

[stuartpb]

Okay, that's pretty much all of those, as relevant, reviewed. Wikimedia's "after" was always more just a quirk of password.reset being too broad (fixed with #127's introduction of a distinction between password.reset.flow and password.reset.onetime), and Persona kind of doesn't matter any more (seeing as how it's shutting down at the end of the month).

password.reset.token.login is now well and truly dead (the "no" values were converted to password.reset.flow.submit.session.own: sustain, with headstone until next review, as part of #128), and password.reset.response: token as a problem is a distant memory.

I'd say this issue is finally safe to close. (Though, now that I look, slides.com appears to have been translated wrong - I was confused about the after again, one of the many reasons I'm glad to have finally killed this lousy field altogether.)

[stuartpb]

Now that persona.org has shut down and I've removed the profile for it (#145), this issue can finally rest.