Giter Site home page Giter Site logo

Comments (8)

MSP-Greg avatar MSP-Greg commented on September 21, 2024 1

@eregon

Sorry for not including more info here. Everything works fine on Ubuntu. The problem is macOS, where TruffleRuby (not head) is tested. Without the above fix in extconf.rb, below is what happens:

truffleruby 23.1.1, like ruby 3.2.2, Oracle GraalVM Native [x86_64-darwin]
RUBYOPT: -r/Users/runner/.rubies/truffleruby-23.1.1/lib/mri/bundler/setup
                         Puma::MiniSSL                   Ruby OpenSSL
OPENSSL_LIBRARY_VERSION: OpenSSL 1.1.1w  11 Sep 2023     OpenSSL 1.1.1w  11 Sep 2023
        OPENSSL_VERSION: OpenSSL 3.1.3 19 Sep 2023       OpenSSL 1.1.1w  11 Sep 2023

Puma compiles with OpenSSL 3.1.3, but at runtime uses 1.1.1w. The log is here.

JFYI, years ago I started watching extension gems re Windows. Now, it's a bit more general, but users have all sorts of problems compiling EventMachine and Puma on macOS where they've got both OpenSSL 1.1.1 and OpenSSL 3.x installed.

Hence, using config info embedded in the Ruby build seems like a good solution, as opposed to forcing users to config OpenSSL with gem build options...

from truffleruby.

MSP-Greg avatar MSP-Greg commented on September 21, 2024

Looking over a few pre-built files, it seems that many vendor the openssl files, so in extconf.rb we added

Dir.exist?("#{RbConfig::TOPDIR}/src/main/c/openssl") # TruffleRuby

One can still use --with-openssl-dir, we're trying to avoid forcing users to do so.

Closing.

from truffleruby.

eregon avatar eregon commented on September 21, 2024

There is #3170 to track this.
Doing it breaks installing grpc, so we'd need to find a workaround so it still works for grpc.

from truffleruby.

eregon avatar eregon commented on September 21, 2024

@MSP-Greg https://github.com/ruby/openssl/pull/653/files is the better workaround until this is added in configure_args

from truffleruby.

eregon avatar eregon commented on September 21, 2024

This will be fixed by #3343.

from truffleruby.

eregon avatar eregon commented on September 21, 2024

#3343 merged.
@MSP-Greg If you used any workaround for this issue, could you revert them if the CI uses truffleruby-head? They won't be needed anymore in that case.

from truffleruby.

eregon avatar eregon commented on September 21, 2024

I found https://github.com/puma/puma/blob/master/ext/puma_http11/extconf.rb#L16.
However I think we need to wait for the 24.0 release to remove that because the Puma CI tests against the latest truffleruby release, not just head (which is useful), and notably on ubuntu 20.04 where there are multiple libssl installed (IIRC).
I added a reminder for myself to do it then.

from truffleruby.

MSP-Greg avatar MSP-Greg commented on September 21, 2024

@eregon

Just checked the 'head' build, thanks for the fix.

RbConfig::CONFIG['configure_args']:
  '--with-openssl-dir=/usr/local/opt/openssl@1.1'
  '--with-libyaml-dir=/usr/local/opt/libyaml'

from truffleruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.