fixes for null pointer de-references

[orc]

fixes for null pointer de-references

[Orc]

It looks like you reformatted a large chunk of the code around your changes; can you give me a diff that just has the changes, and not the whitespace/indentation changes?

[reklis]

git diff -w:

https://gist.github.com/2002442

[Orc]

That's much better.

But the static analyzer is picking up false positives;

in linkyformat(), ref is always carried in as a non-null item (there is one place where it's called with a null and then treated as an image, but that place is, as best as I can tell, never accessed, and when I took it out it made no difference to my test suite.)

in quoteblock(), p->text is known to be non-null when the function is called (it would not have been called unless p->text contained a leading ">") so it does not need to be retested.

in actually_a_table(), the second thing the code does is verify that pp, pp->next, and pp->next->next exist; pp->next will not then go away while I'm validating the format of the table.