Incorrect mapper code generated for mapping from a single property to property of collection element

[orika-mapper]

Incorrect mapper code generated for mapping from a single property to property of collection element

[zafar-iqbal]

Please anyone know it, When this issue will be fixed?
single property to property of collection element.

[brabenetz]

The 'NullpointerException' is fixed by #175.
But the Example Code will only work for mapping to an existing instance which already have one or more elements (works after Bugfix #175 ):

MapperFactory mapperFactory = new DefaultMapperFactory.Builder().build();
mapperFactory.classMap(A.class, B.class)
	.field("stringA", "elementsSet{stringB}")
	.register();

A a = new A();
a.setStringA("test");

// Instead of: B b = mapperFactory.getMapperFacade().map(a, B.class);
B b = new B();
b.getElementsSet().add(new BSetElement());
mapperFactory.getMapperFacade().map(a, b);

assertThat(b.getElementsSet(), hasSize(1));
assertThat(b.getElementsSet().iterator().next().getStringB(), is("test"));

A Workaround could be to use the indexed-Expression, but this is only Supported if the Collection is a java.util.List:

MapperFactory mapperFactory = new DefaultMapperFactory.Builder().build();
mapperFactory.classMap(A.class, B.class)
	.field("stringA", "elementsList[0].stringB")
	.register();

A a = new A();
a.setStringA("test");

B b = mapperFactory.getMapperFacade().map(a, B.class);

assertThat(b.getElementsList(), hasSize(1));
assertThat(b.getElementsList().iterator().next().getStringB(), is("test"));

Another Workaround can be a CustomMapper

MapperFactory mapperFactory = new DefaultMapperFactory.Builder().build();
mapperFactory.classMap(A.class, B.class)
	.customize(new CustomMapper<A, B>() {
		@Override
		public void mapAtoB(A a, B b, MappingContext context) {
			if (StringUtils.isNotEmpty(a.getStringA())) {
				BSetElement bElem = new BSetElement();
				bElem.setStringB(a.getStringA());
				b.getElementsSet().add(bElem);
			}
		}
	})
	.register();
A a = new A();
a.setStringA("test");

B b = mapperFactory.getMapperFacade().map(a, B.class);

assertThat(b.getElementsSet(), hasSize(1));
assertThat(b.getElementsSet().iterator().next().getStringB(), is("test"));

Here is the TestCase I used:
Issue104TestCase.java.txt

[ndr-brt]

Agree with @brabenetz

[ndr-brt]

Fixed by #180