Default mapper with SortedSet throws ClassCastException

[orika-mapper]

Default mapper with SortedSet throws ClassCastException

[elaatifi]

Thanks for reporting this issue.

This case should be fixed by registering TreeSet as default implementation for SortedSet:

factory.registerConcreteType(SortedSet.class, TreeSet.class);

Unfortunately the problem lay in MultiOccurrenceVariableRef#newInstance see here which is kind of dirty method for creating new instances of collection without taking care of registered concrete types for a given interface. This have to be fixed :)

As a matter of workaround you can register a custom mapper for SortedSet:

factory.registerMapper(new CustomMapper<SortedSet<Object>, SortedSet<Object>>() {
    @Override
    public void mapAtoB(SortedSet<Object> a, SortedSet<Object> b, MappingContext context) {
        b.clear();
        b.addAll(mapper.mapAsList(a, context.getResolvedDestinationType().getNestedType(1).getRawType(), context));
    }

    @Override
    public void mapBtoA(SortedSet<Object> a, SortedSet<Object> b, MappingContext context) {
        a.clear();
        b.addAll(mapper.mapAsList(b, context.getResolvedDestinationType().getNestedType(1).getRawType(), context));
    }
});

[yonatang]

Thanks for the workaround! I did struggled around with the registerConcreteType unsuccessfully, trying to get it working. Just for the benefit of the community, you have a few typos in your snippet. The correct code is:

factory.registerConcreteType(SortedSet.class, TreeSet.class);
factory.registerMapper(new CustomMapper<SortedSet<Object>, SortedSet<Object>>() {
    @Override
    public void mapAtoB(SortedSet<Object> a, SortedSet<Object> b, MappingContext context) {
        b.clear();
        b.addAll(mapper.mapAsList(a, context.getResolvedDestinationType().getNestedType(0).getRawType(), context));
    }

    @Override
    public void mapBtoA(SortedSet<Object> a, SortedSet<Object> b, MappingContext context) {
        a.clear();
        a.addAll(mapper.mapAsList(b, context.getResolvedDestinationType().getNestedType(0).getRawType(), context));
    }
});

[elaatifi]

Awesome !

[elaatifi]

UPDATE : Should be fixed in 1.4.6
Adding support of SortedSet and SortedMap interfaces.
Still need to fix : MultiOccurrenceVariableRef#newInstance