CustomMapper ArrayIndexOutOfBoundsException if an intermediate generic superclass is used for a mapper implementation

[orika-mapper]

CustomMapper ArrayIndexOutOfBoundsException if an intermediate generic superclass is used for a mapper implementation

[elaatifi]

Thanks Adam !

[elaatifi]

Forget to mention that you can fix them manually (aType,bType) in the subclass constructor as a workaround

[adammichalik]

Unfortunately I don't think it's possible in that particular case. Since CustomMapper constructor has:

public CustomMapper() {
        java.lang.reflect.Type genericSuperclass = getClass().getGenericSuperclass();
        if (genericSuperclass != null && genericSuperclass instanceof ParameterizedType) {
            ParameterizedType superType = (ParameterizedType)getClass().getGenericSuperclass();
            try {
                aType = TypeFactory.valueOf(superType.getActualTypeArguments()[0]);
                bType = TypeFactory.valueOf(superType.getActualTypeArguments()[1]);
            } catch (IllegalArgumentException e) {
                /* do nothing; this was not extended by a user 
                 * getXXType methods must be manually overridden 
                 */
            }
        }
    }

You can see that (referring to my example) if I construct ConcreteMapper its constructor has to call a constructor of GenericSuperMapper and this in turn calls the constructor of Orika's CustomMapper.

There in CustomMapper constructor, this is ConcreteMapper, so genericSuperclass becomes the GenericSuperMapper generic type, which is still an instance of ParameterizedType. So superType is also equal to the GenericSuperMapper generic type (we could just cast genericSuperclass instead of calling getClass().getGenericSuperclass() again btw.).

But GenericSuperMapper itself has only one type parameter, so the line

 bType = TypeFactory.valueOf(superType.getActualTypeArguments()[1]);

fails with ArrayIndexOutOfBoundsException. The try/catch block catches only IllegalArgumentException, so the ArrayIndexOutOfBoundsException bubbles uncaught, thus failing the whole constructor of the mapper without an option to adjust the A/B types manually.

[elaatifi]

I just pushed a fix, can you please confirm if it fix your issue I also added a quick test.

[adammichalik]

I checked 1.4.7-SNAPSHOT and it works fine with your fix. Thanks!