Linkage problem when orika and the domain model are in different classloaders

[orika-mapper]

Linkage problem when orika and the domain model are in different classloaders

[ndr-brt]

I tried to replicate this with simplification showed in the first post, but i can't replicate the exception, it maps correctly.

There's a possibility to replicate it? or can we consider this closed?

[brabenetz]

sounds similar to #62
Maybe the solution from @Jtalk works:
"The simple workaround is to subclass JavassistCompilerStrategy in your deployment so it's class is loaded by deployment CL. Your overridden class should then be manually applied to the Orika MapperFactory (new DefaultMapperFactory.Builder().compilerStrategy(new YourSubclass()).build() should do the trick)."

[tsoroka]

This issue still reproducible with Tomcat 9.0.17 and Java version > 8. With Java version 8 issue is not reproducible. Orika version 1.5.4. Subclassing of JavassistCompilerStrategy did not help. Can you please fix this issue?

Caused by: java.lang.ClassNotFoundException: ma.glasnost.orika.impl.GeneratedMapperBase
at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583) ~[?:?]
at jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) ~[?:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:521) ~[?:?]
at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
at java.lang.ClassLoader.defineClass(ClassLoader.java:1016) ~[?:?]
at jdk.internal.reflect.GeneratedMethodAccessor59.invoke(Unknown Source) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?]
at javassist.ClassPool.toClass2(ClassPool.java:1183) ~[javassist-3.21.0-GA.jar:?]
at javassist.ClassPool.toClass(ClassPool.java:1164) ~[javassist-3.21.0-GA.jar:?]
at javassist.CtClass.toClass(CtClass.java:1316) ~[javassist-3.21.0-GA.jar:?]
at ma.glasnost.orika.impl.generator.JavassistCompilerStrategy.compileClass(JavassistCompilerStrategy.java:246) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.generator.SourceCodeContext.compileClass(SourceCodeContext.java:228) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.generator.SourceCodeContext.getInstance(SourceCodeContext.java:244) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.generator.MapperGenerator.build(MapperGenerator.java:73) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.DefaultMapperFactory.buildMapper(DefaultMapperFactory.java:1478) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.DefaultMapperFactory.lookupMapper(DefaultMapperFactory.java:738) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.resolveMapper(MapperFacadeImpl.java:568) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.resolveMappingStrategy(MapperFacadeImpl.java:178) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.mapElement(MapperFacadeImpl.java:792) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.mapAsCollection(MapperFacadeImpl.java:622) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.mapAsList(MapperFacadeImpl.java:428) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.generated.Orika_FlightOfferPassengerContextSearchTO_FlightOfferPassengerContextSearch_Mapper341361519670733$38.mapAtoB(Orika_FlightOfferPassengerContextSearchTO_FlightOfferPassengerContextSearch_Mapper341361519670733$38.java) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.mapping.strategy.UseCustomMapperStrategy.map(UseCustomMapperStrategy.java:77) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.map(MapperFacadeImpl.java:253) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.mapElement(MapperFacadeImpl.java:799) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.mapAsCollection(MapperFacadeImpl.java:622) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.MapperFacadeImpl.mapAsList(MapperFacadeImpl.java:428) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.generated.Orika_CheckOfferSearchTO_CheckOfferSearch_Mapper341361496484122$35.mapAtoB(Orika_CheckOfferSearchTO_CheckOfferSearch_Mapper341361496484122$35.java) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.mapping.strategy.UseCustomMapperStrategy.map(UseCustomMapperStrategy.java:77) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.DefaultBoundMapperFacade.map(DefaultBoundMapperFacade.java:137) ~[orika-core-1.5.4.jar:?]
at ma.glasnost.orika.impl.DefaultBoundMapperFacade.map(DefaultBoundMapperFacade.java:94) ~[orika-core-1.5.4.jar:?]

[tsoroka]

Could be fixed as described in https://stackoverflow.com/questions/52321672/orika-wrong-classloader-used-in-case-of-using-embedded-tomcat.